Re: [Sng-devel] sng 1.0.5 vs libpng 1.4

[James C. <cl...@jh...>]

> ...this clearly relates to a libpng API change, and we need to figure
> out when it happened to conditionalize the code properly.

Indeed.

That is why I left it as a simple git diff and not git format-patch output.

I looked at the libpng git repo.  Change "trans" to "trans_alpha" is
commit 6abea7562b which is after the bump to 1.4.0beta74 and before
the bump to 1.4.0beta75.

The change from trans_values to trans_color occurred in commit 56f6396137,
which is 'Imported from libpng-1.4.0beta35.tar', from before the switch
to git.

Based on the git repo, the last change to PNG_LIBPNG_VER_MINOR before
these changes was from 1.2.10 to 1.4.0.  There is no 1.3.

Therefore, your proposed patch in the other reply looks correct.

There are still a bunch of api deprecation warnings, and I get the notice:

  0 sBIT red bits not valid for 8bit/sample image

from almost every png I try.  Converting such a .sng back to png gives
the related warning:

  libpng warning: Invalid sBIT depth specified

So there may be more api changes which affect sng but do not prevent
compilation....

-JimC
-- 
James Cloos <cl...@jh...>         OpenPGP: 1024D/ED7DAEA6