Bug on snap7.net.cs

32/64 bit multi-platform Ethernet S7 PLC communication suite

Brought to you by: davenardella

Bug on snap7.net.cs

Forum: Bugs reporting

Creator: Pablo Agirre

Created: 2015-02-18

Updated: 2015-02-21

Pablo Agirre - 2015-02-18

Hi Davide,

I've found a little typo on GetBitAt() and SetBitAt() in snap7.net.cs (Ver.: 1.3.0)

Line:
byte[] Mask = {0x01,0x02,0x04,0x08,0x10,0x10,0x40,0x80};

Should be:
byte[] Mask = {0x01,0x02,0x04,0x08,0x10,0x20,0x40,0x80};

Mask for Bit 5 is wrong.

Bye

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Davide Nardella - 2015-02-19

Hi Pablo,
it was already fixed into the bugfix release :
http://sourceforge.net/projects/snap7/files/Daily/snap7-bugfix-1.3.0.zip/download

thanks anyway for the report ;)

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Pablo Agirre - 2015-02-21

I'm using last snap7-bugfix-1.3.0 and have found something else:

In: public static void SetBitAt(ref byte[] Buffer, int Pos, int Bit, bool Value)

Why do you use ref for Buffer ?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.