Connection.waitForResponsePacket should not log ERROR when propagating...
Status: Beta
Brought to you by:
orank
In smppapi 0.3.9, if Connection.readNextPacketInternal times out during SMPP bind and a SocketTimeoutException is thrown, the exception is logged as ERROR in Connection.waitForResponsePacket even though the SocketTimeoutException is rethrown and ends up propagating out of the library code.
I think that deciding how to handle exceptions which are propagated out of library code should be up to the user.
I have attached a patch against the PATCH_0_3 branch (I assume this is the bugfix branch for versions 0.3.x? I couldn't even find the Connection class in trunk..) that removes the catch block that logs the SocketTimeoutException such that it propagates out without any ERROR logging.