#897 smplayer freezes for a ~1 sec when taking screenshot (only w/ mpv in smplayer window)

[terpavor]

1. Windows 7, SMPlayer 18.6.0 x64
2. mpv itself is ok. There is no freezing if I use mpv.exe.
3. SMPlayer+"mpv in separate window mode" is ok. Completely smooth playback when taking screenshots if "Advanced->Run MPlayer/mpv in its own window" is checked.
4. SMPlayer+MPlayer is ok.
5. Don't know what exactly is "use_pausing_keep_force" from .smplayer\smplayer.ini used in core.cpp/Core::pausing_prefix(), but setting to false doesn't change anything.
6. “heavier” video == longer freezing. ~1 sec freezing corresponds to full hd.
7. I don't see any dependency on video and interface settings.
8. SMPlayer log excerpt:

...
[13:31:19:301] Core::startMplayer: command: 'O:/Programs/Players/SMPlayer/mpv/mpv.exe --no-config --no-quiet --terminal --no-msg-color --input-file=/dev/stdin --no-fs --vd-lavc-threads=4 --hwdec=auto --sub-auto=fuzzy --vo=direct3d, --audio-device=dsound/1 --ao=dsound, --priority=high --no-input-default-bindings --input-vo-keyboard=no --no-input-cursor --cursor-autohide=no --no-keepaspect --wid=2163954 --monitorpixelaspect=1 --osd-level=1 --osd-scale=1 --osd-bar-align-y=0.6 --sub-ass --embeddedfonts --sub-ass-line-spacing=0 --sub-scale=1 --sub-codepage=CP1251 --vid=1 --sid=no --alang=jap,jpn,jp --slang=ru,rus --sub-pos=100 --volume=53 --cache=65536 --screenshot-template=cap_%F_%p_%02n --screenshot-format=png --screenshot-directory=M:\Pictures\Screenshots\SMPlayer --audio-pitch-correction=yes --af-add=lavfi=[firequalizer=gain='cubic_interpolate(f)':zero_phase=on:wfunc=tukey:delay=0.027:gain_entry='entry(0,0);entry(62.5,0);entry(125,0);entry(250,0);entry(500,0);entry(1000,0);entry(2000,0);entry(4000,0);entry(8000,0);entry(16000,0)'] --volume-max=110 --osd-level=0 --term-playing-msg=MPV_VERSION=${=mpv-version:}
...
[13:31:29:037] BaseGuiPlus::eventFilter: key: QKeySequence("S")
[13:31:29:037] Core::screenshot
[13:31:29:037] Core::screenshot: include_subtitles: false
[13:31:29:038] Core::pausing_prefix
[13:31:29:038] PlayerProcess::writeToStdin: screenshot video single
[13:31:29:038] Core::screenshot: screenshot taken
[13:31:29:039] MPVProcess::parseLine: "Screenshot: 'M:\\Pictures\\Screenshots\\***'"

[terpavor]

It's me again. Freezing occurs because of smplayer.ini->[%General]->screenshot_format=png.
No freezing with jpg. But the issue is still here, because mplayer and "mpv in separate window mode" can take png screenshots without freezing.

---

Reproduced on "18.6.0 x64 portable" with default settings (except jpg->png, of course).

---

Taking a screenshot with "mpv in separate window mode" produces only one line in log:

MPVProcess::parseLine: "Screenshot: 'M:\\Pictures\\Screenshots\\***'"

---

Multiple Screenshots (Shift + D) also have freezing.

---

mpv's png compression options settings doesn't matter since they must be same and default in separate/non-separate window modes because of --no-config flag. Those options and default values:

--screenshot-png-compression=<0-9> [7]
--screenshot-png-filter=<0-5> [5]

No filtering, lower compression rate -> less freeze time, but it's a weird workaround. Taking a screenshot must be async.

[koko]

Might be related. When I upgraded to 19.1.0 I noticed mvp will rarely freeze for 1 sec when switching from/to fullscreen.

Happens only when MVP is set to GPU as output.