#773 Audio equalizer is always on

[Sergey Kondakov]

I've noticed that equalizer is always on, despite the settings. Only if it's set to "disabled" in them, its configuration window is greyed out, despite its being active. I have 'use_audio_equalizer=false' in spplayer.ini but mpv log reports:

[af] Audio filter chain:
[af]   [in] 44100Hz stereo 2ch floatp
[af]   [lavrresample] 44100Hz stereo 2ch float [a]
[af]   [equalizer] 44100Hz stereo 2ch float
[af]   [volume] "softvol" 44100Hz stereo 2ch float
[af]   [lavrresample] 48000Hz stereo 2ch floatp [a]
[af]   [out] 48000Hz stereo 2ch floatp
[af]   [ao] 48000Hz stereo 2ch floatp

The output is JACK server with 48000Hz/float expected format but I also have

audio-format=floatp
audio-samplerate=48000

in mpv.conf. It shouldn't pertain to equalizer issue, it just means that smplayer also needlesly inserts another lavrresample filter too. "Naked" mpv gives out proper:

[af] Audio filter chain:
[af]   [in] 44100Hz stereo 2ch floatp
[af]   [lavrresample] 48000Hz stereo 2ch floatp [a]
[af]   [out] 48000Hz stereo 2ch floatp
[af]   [ao] 48000Hz stereo 2ch floatp

smplayer seem to force equalizer only on startup, if mpv is restarted at runtime because of some configuration changes, equalizer seem to be missing as it should. It may, unlikely, be result of some distribution patches.

[Ricardo Villalba]

I cannot reproduce the problem in my computer. Can you send the mpv log (option in the menu View) after playing a video?

[Sergey Kondakov]

The smplayer build is https://build.opensuse.org/package/show/home:X0F:HSF/smplayer?rev=7
The mpv build is https://build.opensuse.org/package/show/home:X0F:HSF/mpv?rev=24

[Ricardo Villalba]

Could you send the smplayer log as well?

[Sergey Kondakov]

Here. /usr/local/bin/mpv.sh file from log is:

1 2	#!/bin/sh nice -n -10 ionice -c 2 -n 1 mpv "$@"

while there is this line in /etc/security/limits.conf:

@users soft priority -5

which results in mpv having -15 niceness.

[Ricardo Villalba]

According to the logs SMPlayer doesn't enable the audio equalizer on startup. However the equalizer filter is set later when the video is playing. I can't find in the log a command from SMPlayer to set that filter. Maybe mpv enabled that filter on its own?

In my computer I'm not able to reproduce the problem.

[Sergey Kondakov]

Maybe mpv enabled that filter on its own?

I just figured out musterious double lavrresample.
After launched standalone mpv with a song, it gave:

[af] Audio filter chain:
[af]   [in] 44100Hz stereo 2ch s16
[af]   [lavrresample] 48000Hz stereo 2ch float [a]
[af]   [out] 48000Hz stereo 2ch float
[af]   [ao] 48000Hz stereo 2ch float

after startup but as soon as I pressed "0" to add volume beyond initial 100% it wrote:

[cplayer] Run command: add, flags=9, args=[volume, 2.000000]
[cplayer] Inserting volume filter.
[af] Adding filter volume 
[af] Removing filter lavrresample 
[af] Adding filter lavrresample 
[af] Adding filter lavrresample 
[af] Audio filter chain:
[af]   [in] 44100Hz stereo 2ch s16
[af]   [lavrresample] 44100Hz stereo 2ch float [a]
[af]   [volume] "softvol" 44100Hz stereo 2ch float
[af]   [lavrresample] 48000Hz stereo 2ch float [a]
[af]   [out] 48000Hz stereo 2ch float
[af]   [ao] 48000Hz stereo 2ch float
[volume] volume gain: 1.061208

it seem to always do so but all that doesn't explain equlizer. It's definitely SMPlayer who forces it because the whole reason I noticed it is because it forced old values from smplayer.ini's 'audio_equalizer=' parameter which I weren't using for few years.

[Ricardo Villalba]

Yes I think the equailizer filter is enabled by mistake when SMPlayer tries to update the controls of the audio equalizer. I'll try to fix it.

[Ricardo Villalba]

I think the problem is fixed in svn r8141

[Sergey Kondakov]

I've applied that patch to the latest release and it seems fine now.