Hi all,
I've already spoken with Giuseppe about the lates commit activity and
I wish to advice all developers about the commit policy I consider
correct, not only on SmartWeb, but on every project.
In my opinion whenever you commit you should commit "One Activity".
The misunderstanding usually comes on the Activity term.
I consider an activity a set of changes to one or more files which are
strictly related. As a guideline, changes can be considered related
if:
- the commit message is the same
- a change on one file depends on a change on another file
- the changes are related each other by the same issue (in the tracker
or in the forum doesn't matter)
It is bad habit to:
- commit more than one activity together, as you prevent others to
rollback a single modification, may be for testing purposes or
something else
- commit one activity in multiple commits, as you complicate the
identification of the modification process.
--
Roberto Lo Giacco
|
