The registration handler interface is completely wrong and was
reverted to a very primitive state!
Many mistakes could be found on that interface:
1 - the onRegister method, while correct from a naming perspective, is
not the only method needed to perform registration! The verify()
method is a must and the update() method was deleted instead to be
renamed onUpdate().
2 - the prologue comment stating hte class is open source is missing!
3 - the existing javadoc comments where wiped out!!!
4 - the definition of the states String array in the interface is
probably a nonsense as it's implicitly STATIC and FINAL!!!!
I suggest a complete rollback and a rethink about what have been done.
More mistakes can be found on the EmailVerifierRegistrationHandler
implementation like the usage of the RuntimeException subclass
IllegalStateException which is used in threading contextes!!!
I'll attach the original interface (RegistrationHandler.java) and what
I suggest (RegistrationHandler.new) for further discussion.
|
