From: Bruce A. <ba...@gr...> - 2003-05-23 13:37:24
|
Guilhem, Thank you very much for the patch! And for the new Attribute interpretation. There are still a few things needed. Please see the comment in atacmds.c that reads: // When you add additional items to this list, you should then: // 0 -- update this list // 1 -- modify the following function parse_attribute_def() // 2 -- modify ataPrintSmartAttribRawValue() // 3 - modify ataPrintSmartAttribName() // 4 -- add #define PRESET_N_DESCRIPTION at top of knowndrives.c // 5 -- add drive in question into knowndrives[] table in knowndrives.c // 6 -- update smartctl.8 // 7 -- update smartd.8 // 8 -- do "make smartd.conf.5" to update smartd.conf.5 // 9 -- update CHANGELOG file A few of these items are missing. Could you send a revised patch that includes all of them? Alternatively, if you'd like to become a smartmontools developer I would be happy to add you to the list of developers. You can then check your changes directly into CVS. One minor comment on your code. You can put the definitions: "long load,unload" inside the local block so that it reads: if (defs[193]==1){ // dissociated long load=(short)attribute->raw[0]+ ((short)attribute->raw[1]<<8) + ((short)attribute->raw[2]<<16); long unload=(short)attribute->raw[3]+ ((short)attribute->raw[4]<<8) + ((short)attribute->raw[5]<<16); out+=sprintf(out, "%lu / %lu", load, unload); } Tu peut aussi m'ecrire in francais s'il tu plait. Je suis en train de l'oublier, parce que ma femme est italienne. Merci encore! Bruce Allen |