From: Cyrus R. <cr...@gm...> - 2008-02-17 07:03:13
|
Well, it's worse than that because even trying to turn it on will turn it off. Best to not mess with it at all, or you'll have to build one of those bootable Linux CD's containing smartctl and boot it and turn it back on. Or you can just apply the following patch, which perhaps can get integrated into the upcoming release? --- os_freebsd.cpp.orig 2008-02-16 23:47:31.000000000 -0700 +++ os_freebsd.cpp 2008-02-16 23:49:39.000000000 -0700 @@ -358,7 +358,8 @@ case AUTO_OFFLINE: // NOTE: According to ATAPI 4 and UP, this command is obsolete request.u.ata.feature=ATA_SMART_AUTO_OFFLINE; - request.u.ata.lba=select|(0xc24f<<8); + request.u.ata.lba=0xc24f<<8; + request.u.ata.count=select; request.flags=ATA_CMD_CONTROL; break; case AUTOSAVE: |
From: Bruce A. <ba...@gr...> - 2008-02-20 21:36:35
|
I passed this on to our FreeBSD maintainer. On Sun, 17 Feb 2008, Cyrus Rahman wrote: > Well, it's worse than that because even trying to turn it on will turn > it off. Best to not mess with it at all, or you'll have to build one > of those bootable Linux CD's containing smartctl and boot it and turn > it back on. > > Or you can just apply the following patch, which perhaps can get > integrated into the upcoming release? > > --- os_freebsd.cpp.orig 2008-02-16 23:47:31.000000000 -0700 > +++ os_freebsd.cpp 2008-02-16 23:49:39.000000000 -0700 > @@ -358,7 +358,8 @@ > case AUTO_OFFLINE: > // NOTE: According to ATAPI 4 and UP, this command is obsolete > request.u.ata.feature=ATA_SMART_AUTO_OFFLINE; > - request.u.ata.lba=select|(0xc24f<<8); > + request.u.ata.lba=0xc24f<<8; > + request.u.ata.count=select; > request.flags=ATA_CMD_CONTROL; > break; > case AUTOSAVE: > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > Smartmontools-support mailing list > Sma...@li... > https://lists.sourceforge.net/lists/listinfo/smartmontools-support > |
From: Eduard M. <mar...@ro...> - 2008-02-22 02:32:08
|
The patch looks fine, and I don't see any reason to not include it. Bruce, can you go ahead and apply it? As my development machine is currently down :( Thanks, Ed Bruce Allen wrote: > I passed this on to our FreeBSD maintainer. > > On Sun, 17 Feb 2008, Cyrus Rahman wrote: > >> Well, it's worse than that because even trying to turn it on will turn >> it off. Best to not mess with it at all, or you'll have to build one >> of those bootable Linux CD's containing smartctl and boot it and turn >> it back on. >> >> Or you can just apply the following patch, which perhaps can get >> integrated into the upcoming release? >> >> --- os_freebsd.cpp.orig 2008-02-16 23:47:31.000000000 -0700 >> +++ os_freebsd.cpp 2008-02-16 23:49:39.000000000 -0700 >> @@ -358,7 +358,8 @@ >> case AUTO_OFFLINE: >> // NOTE: According to ATAPI 4 and UP, this command is obsolete >> request.u.ata.feature=ATA_SMART_AUTO_OFFLINE; >> - request.u.ata.lba=select|(0xc24f<<8); >> + request.u.ata.lba=0xc24f<<8; >> + request.u.ata.count=select; >> request.flags=ATA_CMD_CONTROL; >> break; >> case AUTOSAVE: >> >> ------------------------------------------------------------------------- >> This SF.net email is sponsored by: Microsoft >> Defy all challenges. Microsoft(R) Visual Studio 2008. >> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ >> _______________________________________________ >> Smartmontools-support mailing list >> Sma...@li... >> https://lists.sourceforge.net/lists/listinfo/smartmontools-support >> > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > Smartmontools-support mailing list > Sma...@li... > https://lists.sourceforge.net/lists/listinfo/smartmontools-support |
From: Bruce A. <ba...@gr...> - 2008-02-23 07:33:31
|
Done! On Thu, 21 Feb 2008, Eduard Martinescu wrote: > The patch looks fine, and I don't see any reason to not include it. > > Bruce, can you go ahead and apply it? As my development machine is currently > down :( > > Thanks, > Ed > > Bruce Allen wrote: >> I passed this on to our FreeBSD maintainer. >> >> On Sun, 17 Feb 2008, Cyrus Rahman wrote: >> >>> Well, it's worse than that because even trying to turn it on will turn >>> it off. Best to not mess with it at all, or you'll have to build one >>> of those bootable Linux CD's containing smartctl and boot it and turn >>> it back on. >>> >>> Or you can just apply the following patch, which perhaps can get >>> integrated into the upcoming release? >>> >>> --- os_freebsd.cpp.orig 2008-02-16 23:47:31.000000000 -0700 >>> +++ os_freebsd.cpp 2008-02-16 23:49:39.000000000 -0700 >>> @@ -358,7 +358,8 @@ >>> case AUTO_OFFLINE: >>> // NOTE: According to ATAPI 4 and UP, this command is obsolete >>> request.u.ata.feature=ATA_SMART_AUTO_OFFLINE; >>> - request.u.ata.lba=select|(0xc24f<<8); >>> + request.u.ata.lba=0xc24f<<8; >>> + request.u.ata.count=select; >>> request.flags=ATA_CMD_CONTROL; >>> break; >>> case AUTOSAVE: >>> >>> ------------------------------------------------------------------------- >>> This SF.net email is sponsored by: Microsoft >>> Defy all challenges. Microsoft(R) Visual Studio 2008. >>> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ >>> _______________________________________________ >>> Smartmontools-support mailing list >>> Sma...@li... >>> https://lists.sourceforge.net/lists/listinfo/smartmontools-support >>> >> >> ------------------------------------------------------------------------- >> This SF.net email is sponsored by: Microsoft >> Defy all challenges. Microsoft(R) Visual Studio 2008. >> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ >> _______________________________________________ >> Smartmontools-support mailing list >> Sma...@li... >> https://lists.sourceforge.net/lists/listinfo/smartmontools-support > |
From: Bruce A. <ba...@gr...> - 2008-02-23 06:43:26
|
Patch applied to CVS. Do you need a similar patch for AUTOSAVE? This seems to have the count registered wired to 0x01 not to the value of 'select'. On Sun, 17 Feb 2008, Cyrus Rahman wrote: > Well, it's worse than that because even trying to turn it on will turn > it off. Best to not mess with it at all, or you'll have to build one > of those bootable Linux CD's containing smartctl and boot it and turn > it back on. > > Or you can just apply the following patch, which perhaps can get > integrated into the upcoming release? > > --- os_freebsd.cpp.orig 2008-02-16 23:47:31.000000000 -0700 > +++ os_freebsd.cpp 2008-02-16 23:49:39.000000000 -0700 > @@ -358,7 +358,8 @@ > case AUTO_OFFLINE: > // NOTE: According to ATAPI 4 and UP, this command is obsolete > request.u.ata.feature=ATA_SMART_AUTO_OFFLINE; > - request.u.ata.lba=select|(0xc24f<<8); > + request.u.ata.lba=0xc24f<<8; > + request.u.ata.count=select; > request.flags=ATA_CMD_CONTROL; > break; > case AUTOSAVE: > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > Smartmontools-support mailing list > Sma...@li... > https://lists.sourceforge.net/lists/listinfo/smartmontools-support > |
From: Cyrus R. <cr...@gm...> - 2008-02-23 09:25:37
|
> Patch applied to CVS. Do you need a similar patch for AUTOSAVE? This > seems to have the count registered wired to 0x01 not to the value of > 'select'. This is correct, as things stand ataDisableAutoSave() will do the same thing as ataEnableAutoSave(), namely, it will enable autosave. Good catch! |
From: Bruce A. <ba...@gr...> - 2008-02-24 07:46:57
|
Hi Cyrus, Could you please test and send a patch for AUTOSAVE? Cheers, Bruce On Sat, 23 Feb 2008, Cyrus Rahman wrote: >> Patch applied to CVS. Do you need a similar patch for AUTOSAVE? This >> seems to have the count registered wired to 0x01 not to the value of >> 'select'. > > This is correct, as things stand ataDisableAutoSave() will do the same > thing as ataEnableAutoSave(), namely, it will enable autosave. Good > catch! > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > Smartmontools-support mailing list > Sma...@li... > https://lists.sourceforge.net/lists/listinfo/smartmontools-support > |
From: Bruce A. <ba...@gr...> - 2008-02-27 19:34:19
|
Hi Cyrus, >> Could you please test and send a patch for AUTOSAVE? > I've made such a patch and I tried testing it, but for whatever reasons > it fails to turn on or off AUTOSAVE. I don't know if it's a feature of > the drive or something else. I'm setting up a second machine to test > this with a different drive and I'll have that done shortly, after which > I will send you a patch and my test conclusion. I suggest that you also review the ATA-3 spec where this is documented: http://147.145.44.154/ftp/t13/project/d2008r7b-ATA-3.pdf Please see page 87. Sector count register should be 0xf1 to enable autosave and 0x00 to disable it. > Sorry not to get back to you sooner but I am getting over the cold from > down under. No problem. We are curently testing a 5.38 stable release. If you can figure this out in the next couple of days, then we could get the patch into that release. Cheers, Bruce |
From: Cyrus R. <cr...@gm...> - 2008-02-29 01:03:06
|
Bruce, > Could you please test and send a patch for AUTOSAVE? diff -u os_freebsd.cpp.o1 os_freebsd.cpp --- os_freebsd.cpp.o1 2008-02-24 09:04:06.000000000 -0700 +++ os_freebsd.cpp 2008-02-28 17:55:27.000000000 -0700 @@ -364,8 +364,8 @@ break; case AUTOSAVE: request.u.ata.feature=ATA_SMART_AUTOSAVE; - request.u.ata.count=0xf1; // to enable autosave request.u.ata.lba=0xc24f<<8; + request.u.ata.count=select; // to enable/disable autosave request.flags=ATA_CMD_CONTROL; break; case IMMEDIATE_OFFLINE: I have tested this patch on two different types of drives and in both cases I was unable to affect the actual AUTOSAVE state (which remained on). I see no problems with the corrected code, though, and in any case it is no worse than the obvious error that was present before. Perhaps someone with a different drive will be able to test this further. Inspection of the netbsd and openbsd code reveals the exact same problems corrected in this set of freebsd patches - so perhaps the maintainers of those can correct them? If no one steps up I will be happy to submit patches but I cannot test them at this time. Thanks for bringing this second problem to my attention. Cyrus |
From: Bruce A. <ba...@gr...> - 2008-02-29 01:23:37
|
Cyrus, OK. Will put this into 5.38 stable release and NetBSD code. Segey, do you approve? Cheers, Bruce On Thu, 28 Feb 2008, Cyrus Rahman wrote: > Bruce, > >> Could you please test and send a patch for AUTOSAVE? > > diff -u os_freebsd.cpp.o1 os_freebsd.cpp > --- os_freebsd.cpp.o1 2008-02-24 09:04:06.000000000 -0700 > +++ os_freebsd.cpp 2008-02-28 17:55:27.000000000 -0700 > @@ -364,8 +364,8 @@ > break; > case AUTOSAVE: > request.u.ata.feature=ATA_SMART_AUTOSAVE; > - request.u.ata.count=0xf1; // to enable autosave > request.u.ata.lba=0xc24f<<8; > + request.u.ata.count=select; // to enable/disable autosave > request.flags=ATA_CMD_CONTROL; > break; > case IMMEDIATE_OFFLINE: > > I have tested this patch on two different types of drives and in both > cases I was unable to affect the actual AUTOSAVE state (which remained > on). I see no problems with the corrected code, though, and in any > case it is no worse than the obvious error that was present before. > Perhaps someone with a different drive will be able to test this > further. > > Inspection of the netbsd and openbsd code reveals the exact same > problems corrected in this set of freebsd patches - so perhaps the > maintainers of those can correct them? If no one steps up I will be > happy to submit patches but I cannot test them at this time. > > Thanks for bringing this second problem to my attention. > > Cyrus > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > Smartmontools-support mailing list > Sma...@li... > https://lists.sourceforge.net/lists/listinfo/smartmontools-support > |
From: Sergey S. <sha...@us...> - 2008-02-29 20:59:45
Attachments:
jaa.diff
|
On Thu, Feb 28, 2008 at 07:23:32PM -0600, Bruce Allen wrote: >Cyrus, > >OK. Will put this into 5.38 stable release and NetBSD code. Segey, do >you approve? Uh oh. I will have to double-check, but os_netbsd is broken in more ways than (this) one. In particular, ATACMD_READREG has to be set in req.flags for commands that return status in device registers; this breaks STATUS_CHECK, AUTOSAVE and AUTO_OFFLINE commands... Preliminary fix attached. -- Sergey Svishchev |
From: Bruce A. <ba...@gr...> - 2008-03-01 08:27:22
|
Sergey, I have poor access at the moment. Could you check in the os_netbsd and os_freebsd changes? Cheers, Bruce On Fri, 29 Feb 2008, Sergey Svishchev wrote: > On Thu, Feb 28, 2008 at 07:23:32PM -0600, Bruce Allen wrote: >> Cyrus, >> >> OK. Will put this into 5.38 stable release and NetBSD code. Segey, do you >> approve? > > Uh oh. I will have to double-check, but os_netbsd is broken in more > ways than (this) one. In particular, ATACMD_READREG has to be set in > req.flags for commands that return status in device registers; this > breaks STATUS_CHECK, AUTOSAVE and AUTO_OFFLINE commands... > > Preliminary fix attached. > > |
From: Sergey S. <sha...@us...> - 2008-03-03 22:40:16
|
On Sat, Mar 01, 2008 at 02:27:14AM -0600, Bruce Allen wrote: >Sergey, > >I have poor access at the moment. Could you check in the os_netbsd and >os_freebsd changes? Done. -- Sergey Svishchev |
From: Bruce A. <ba...@gr...> - 2008-03-04 10:42:42
|
Thanks! On Tue, 4 Mar 2008, Sergey Svishchev wrote: > On Sat, Mar 01, 2008 at 02:27:14AM -0600, Bruce Allen wrote: >> Sergey, >> >> I have poor access at the moment. Could you check in the os_netbsd and >> os_freebsd changes? > > Done. > > |