From: Bruce A. <ba...@gr...> - 2006-06-15 21:28:36
|
Sergey, can you comment please? ---------- Forwarded message ---------- Date: Thu, 15 Jun 2006 13:48:27 -0400 From: Damon Brodie <da...@br...> To: sma...@li... Subject: [smartmontools-support] Corrupt output from smartctl on NetBSD Hi, I just downloaded and installed 5.36 on an x86 64 bit NetBSD install, and while it mostly works, parts of the output from smartctl seem to have a byte swapping issue. (The 5.32 version from pkgsrc does not exhibit this problem - it may be a local patch to NetBSD's pkgsrc that corrects it: smartctl version 5.36 [x86_64--netbsd] Copyright (C) 2002-6 Bruce Allen Home page is http://smartmontools.sourceforge.net/ === START OF INFORMATION SECTION === Device Model: aMtxro6 2B050S Serial Number: 5B40Y7HZ Firmware Version: ABCNE100 User Capacity: 251,000,193,024 bytes Device is: Not in smartctl database [for details use: -P showall] ATA Version is: 7 ATA Standard is: ATA/ATAPI-7 T13 1532D revision 0 Local Time is: Thu Jun 15 13:30:43 2006 EDT SMART support is: Available - device has SMART capability. SMART support is: Enabled In the above output the Model, SN and Firmware seem to have bytes swapped. The Device Model should read: Matrox 6B250S0 Is this a known issue? I can look into the pkgsrc patches and try and work it out, but I thought I would try here first. Thanks, Damon _______________________________________________ Smartmontools-support mailing list Sma...@li... https://lists.sourceforge.net/lists/listinfo/smartmontools-support |
From: Leon W. <le...@ma...> - 2006-06-16 10:53:28
|
Bruce Allen wrote: > Sergey, can you comment please? > > ---------- Forwarded message ---------- > > Device Model: aMtxro6 2B050S > > In the above output the Model, SN and Firmware seem to have bytes swapped. The Device Model should read: Matrox 6B250S0 Let me see: "aMt" -> "Mat" and "xro" -> "rox". Hhhhhmnnnn, not as simple as byte-swapping. I bet the brand reads Maxtor on the label :-) Good weekend to you all, Leon. |
From: Bruce A. <ba...@gr...> - 2006-06-16 10:59:07
|
On Fri, 16 Jun 2006, Leon Woestenberg wrote: > Bruce Allen wrote: >> Sergey, can you comment please? >> >> ---------- Forwarded message ---------- >> >> Device Model: aMtxro6 2B050S >> >> In the above output the Model, SN and Firmware seem to have bytes swapped. The Device Model should read: Matrox 6B250S0 > Let me see: "aMt" -> "Mat" and "xro" -> "rox". > > Hhhhhmnnnn, not as simple as byte-swapping. It should not be called 'byte-swapping'. The ATA standard specifies data structures composed of 256 words of 16 bits each. The order in which the two 8-bit characters is packed is reversed when the OS reads the data from the disk, this is what results. Cheers, Bruce |
From: Bernd M. <melchers@CIS.FU-Berlin.DE> - 2006-06-16 12:49:14
|
> Bruce Allen wrote: > > Sergey, can you comment please? > > > > ---------- Forwarded message ---------- > > > > Device Model: aMtxro6 2B050S > > > > In the above output the Model, SN and Firmware seem to have bytes swapped. The Device Model should read: Matrox 6B250S0 > Let me see: "aMt" -> "Mat" and "xro" -> "rox". Wrong! aMtxro6 2B050S -> aM tx ro 6 2B 05 0S -> Ma xt or 6 b2 50 S0 -> Maxtor 6B250S0 simple byte swapping... > > Hhhhhmnnnn, not as simple as byte-swapping. > > I bet the brand reads Maxtor on the label :-) > > Good weekend to you all, > > Leon. > > > _______________________________________________ > Smartmontools-support mailing list > Sma...@li... > https://lists.sourceforge.net/lists/listinfo/smartmontools-support mit freundlichen Grüßen Bernd Melchers -- Archiv- und Backup-Service | fab...@ze... Freie Universität Berlin | Tel. (030) 838-55905 und -56066 |
From: Damon B. <da...@br...> - 2006-06-16 19:09:31
|
Hi, This is the patch in pkgsrc that seems to fix the issue: --- ataprint.c.orig 2004-06-04 22:59:16.000000000 +0200 +++ ataprint.c 2006-04-21 01:10:45.000000000 +0200 @@ -90,7 +90,14 @@ char tmp[65]; n = n > 64 ? 64 : n; +#ifndef __NetBSD__ swapbytes(tmp, in, n); +#else + if (isbigendian()) + strncpy(tmp, in, n); + else + swapbytes(tmp, in, n); +#endif tmp[n] = '\0'; trim(out, tmp); } On Fri, Jun 16, 2006 at 12:53:26PM +0200, Leon Woestenberg wrote: > Bruce Allen wrote: > > Sergey, can you comment please? > > > > ---------- Forwarded message ---------- > > > > Device Model: aMtxro6 2B050S > > > > In the above output the Model, SN and Firmware seem to have bytes swapped. The Device Model should read: Matrox 6B250S0 > Let me see: "aMt" -> "Mat" and "xro" -> "rox". > > Hhhhhmnnnn, not as simple as byte-swapping. > > I bet the brand reads Maxtor on the label :-) > > Good weekend to you all, > > Leon. > > > _______________________________________________ > Smartmontools-support mailing list > Sma...@li... > https://lists.sourceforge.net/lists/listinfo/smartmontools-support |
From: Bruce A. <ba...@gr...> - 2006-06-16 21:14:01
|
Damon, thanks, this definitely looks like the fix. Sergey, we're still waiting for your comment. We could apply this directly to the source code. The only reason NOT to apply this patch would be if this patch is meant to workaround a bug in the NetBSD kernel which has been (or is being) fixed. Cheers, Bruce On Fri, 16 Jun 2006, Damon Brodie wrote: > Hi, > > This is the patch in pkgsrc that seems to fix the issue: > > --- ataprint.c.orig 2004-06-04 22:59:16.000000000 +0200 > +++ ataprint.c 2006-04-21 01:10:45.000000000 +0200 > @@ -90,7 +90,14 @@ > char tmp[65]; > > n = n > 64 ? 64 : n; > +#ifndef __NetBSD__ > swapbytes(tmp, in, n); > +#else > + if (isbigendian()) > + strncpy(tmp, in, n); > + else > + swapbytes(tmp, in, n); > +#endif > tmp[n] = '\0'; > trim(out, tmp); > } > > > On Fri, Jun 16, 2006 at 12:53:26PM +0200, Leon Woestenberg wrote: >> Bruce Allen wrote: >>> Sergey, can you comment please? >>> >>> ---------- Forwarded message ---------- >>> >>> Device Model: aMtxro6 2B050S >>> >>> In the above output the Model, SN and Firmware seem to have bytes swapped. The Device Model should read: Matrox 6B250S0 >> Let me see: "aMt" -> "Mat" and "xro" -> "rox". >> >> Hhhhhmnnnn, not as simple as byte-swapping. >> >> I bet the brand reads Maxtor on the label :-) >> >> Good weekend to you all, >> >> Leon. >> >> >> _______________________________________________ >> Smartmontools-support mailing list >> Sma...@li... >> https://lists.sourceforge.net/lists/listinfo/smartmontools-support > |
From: Sergey S. <sha...@us...> - 2006-06-20 22:06:51
|
On Fri, Jun 16, 2006 at 04:13:44PM -0500, Bruce Allen wrote: >Damon, thanks, this definitely looks like the fix. Sergey, we're still=20 >waiting for your comment. We could apply this directly to the source=20 >code. The only reason NOT to apply this patch would be if this patch is= =20 >meant to workaround a bug in the NetBSD kernel which has been (or is=20 >being) fixed. I've committed the fix (as provided in pkgsrc). And it was way, way overdue (my fault)... --=20 Sergey Svishchev |
From: Bruce A. <ba...@gr...> - 2006-06-21 07:07:31
|
Sergey, thanks for doing this. Better late than never! Cheers, Bruce On Wed, 21 Jun 2006, Sergey Svishchev wrote: > On Fri, Jun 16, 2006 at 04:13:44PM -0500, Bruce Allen wrote: >> Damon, thanks, this definitely looks like the fix. Sergey, we're still >> waiting for your comment. We could apply this directly to the source code. >> The only reason NOT to apply this patch would be if this patch is meant to >> workaround a bug in the NetBSD kernel which has been (or is being) fixed. > > I've committed the fix (as provided in pkgsrc). And it was way, way overdue > (my fault)... > > -- > Sergey Svishchev > |