From: Roy Badami <roy.badami@gl...> - 2005-09-20 22:23:27
Two problems with the FreeBSD RCNG support in the startup script
The RCNG case is missing an 'exit 0' causing the startup script to
comlain that 'SOMETHING IS WRONG WITH THE SMARTD STARTUP SCRIPT'
The code needs to initialise smartd_enable to "NO" if it's not already
set (otherwise the RCNG code will complain if the user hasn't set it).
It is also traditional to initialise smartd_flags (to the empty string
if there's nothing more appropriate)
There doesn't seem to be a single standard idiom for this, but this
seems as good an approach as any:
From: Roy Badami <roy.badami@gl...> - 2005-09-20 22:31:31
Here is a patch:
--- smartd.sh.old Tue Sep 20 21:48:10 2005
+++ smartd.sh Tue Sep 20 23:27:53 2005
@@ -291,6 +291,8 @@
elif [ -r /etc/defaults/rc.conf ]; then
# Not a 5.x system, try the default location for variables
@@ -304,6 +306,7 @@
if [ -r /etc/rc.subr ]; then
# Use new functionality from RC-NG
+ exit 0
case "$1" in
Thanks for your problem reports and patch. I will look at integrating this
into the CVS repository shortly. I have some other patches also waiting and
am hoping to finally get a chance to look at them all this weekend.
Get latest updates about Open Source Projects, Conferences and News.