From: Bruce A. <ba...@gr...> - 2009-01-08 09:44:52
|
Hi Doug, > I think that we should accept the first (lower) byte of 0x4f for success > (or 0xf4 for failure) since it is placed below the 18 byte SCSI-2 sense > buffer length limit in a SAT ATA Return descriptor. Silently ignore in > incorrect upper byte (0xc2 for success or 0x2c for failure) unless '-r > ioctl[,<n>]' is given, in which case smartmontools can explain its > assumption/compromise. > > A patch is attached for consideration. I have not checked the patch in detail, but I think the basic idea is fine: check the part of the response which survives the overly-short buffer limit, with a diagnostic warning if the remaining part of the response is missing. Cheers, Bruce |