Menu

#5 Inconsistent coordinate system for auth fail message

V1.4.0 release
closed
None
2023-02-27
2023-01-03
No

When I added the "passwd_feedback" message to slim itself (from slimlock), I didn't notice the inconsistency in window references. As a result, the coordinates specified are treated as relative to the panel, where slimlock made them relative to the screen. The other message types ("msg", "session") are always screen-relative, although "welcome" is inconsistent. Pure panel texts (input_xxx, username, password) are panel-relative. It should be more consistent.

Discussion

  • Robert Pearce

    Robert Pearce - 2023-01-03

    Rather than break everyone's themes, I'll keep the overall "two message classes" but make passwd_feedback always screen-relative. This will be a breaking change for users of V1.3.7 through V1.3.9 but only if they've enabled password feedback.
    For distros who are adopting V1.3.9 now, I recommend using the attached patch, to avoid confusion.

     
  • Robert Pearce

    Robert Pearce - 2023-01-03
    • assigned_to: Robert Pearce
    • Milestone: Unspecified --> V1.4.0 release
     
  • Robert Pearce

    Robert Pearce - 2023-02-27
    • status: open --> closed
     
  • Robert Pearce

    Robert Pearce - 2023-02-27

    Fixed in V1.4.0

     

Log in to post a comment.