Re: [sleuthkit-developers] [sleuthkit-users] TSK 4.1.0 released

[Brian C. <ca...@sl...>]

Ughhh.   I have no clue what that code is supposed to do (my CRC calculation knowledge is a bit fuzzy these days -- that is what libraries are for).  It was part of a code submission.  

Looks like no one is using that function though.  Delete the entire generate_crc_table method (everything you copy and pasted) and try it again.  Mine still compiles. 

I checked in a version that removes this.



On Jun 22, 2013, at 2:27 PM, Greg Freemyer <gre...@gm...> wrote:

> Brian,
> 
> In crc.c I'm getting a warning (that is causing my build to fail)
> about the assignment:
> 
>        crctab[i]= crc;
> 
> The complaint is crctab is a table of short ints, and crc is a long.
> 
> My c skills are rusty, but if you can send me the patch I'd appreciate it.
> 
> === relevant code
> void generate_crc_table(short *crctab[], p_cm_t p_cm){
>    int i, j;
>    unsigned long bit, crc;
>    unsigned long crchighbit = (unsigned long)1 << (p_cm->cm_width-1);
>    unsigned long crcmask = ((((unsigned long)1<<(p_cm->cm_width-1))-1)<<1)|1;
> 
>    for (i=0; i<256; i++)
>    {
>        crc=(unsigned long)i;
>        if(p_cm->cm_refin) crc = reflect(crc,8);
>        crc <<= p_cm->cm_width-8;
>        for(j=0; j<8; j++)
>        {
>            bit = crc & crchighbit;
>            crc <<=1;
>            if(bit) crc ^=p_cm->cm_poly;
>        }
>        if(p_cm->cm_refin) crc = reflect(crc,p_cm->cm_width);
>        crc &= crcmask;
>        crctab[i]= crc;
>    }
>    return;
> }
> ===
> 
> Thanks
> Greg
> -- 
> Greg Freemyer
> Chief Technology Officer
> Intelligent Avatar Corporation
> 
> (678) 653-4860
> Gre...@gm...
> http://www.linkedin.com/in/gregfreemyer
> CNN/TruTV Aired Forensic Imaging Demo -
>   http://insession.blogs.cnn.com/2010/03/23/how-computer-evidence-gets-retrieved/
> 
> 
> On Mon, Jun 17, 2013 at 5:57 PM, Brian Carrier <ca...@sl...> wrote:
>> Version 4.1.0 of The Sleuth Kit is finally available.  It adds many commonly requested features:
>> - YAFFS2 and Ext4 support (from viaForensics and Kevin Fairbanks)
>> - Framework runs on Linux and OS X.
>> - Lots of other less minor things in comparison (see http://sleuthkit.org/sleuthkit/history.php for details)
>> 
>> http://sleuthkit.org/sleuthkit/download.php
>> 
>> A note on YAFFS2, though I'm sure I'll be responding to many questions like this in the future. The layout of the flash memory spare area is not defined in the YAFFS2 spec. The viaForensics patch had a format that they commonly saw and we (Basis Technology) updated it with some layouts that we also came across.  Ideally, TSK would allow the caller to specify the layout, but that feature does not yet exist.
>> 
>> See some notes here on the topic:
>>    http://wiki.sleuthkit.org/index.php?title=YAFFS2_Implementation_Notes
>> 
>> I've cc:ed sleuthkit-developers on this because this version made  some development environment changes.  Previously, include paths were '/usr/local/include/tsk3'...'  Well, it's no longer TSK3.  The number was removed so that it does not need to be updated with major version changes. So, update your code to remove the '3'.
>> 
>> thanks,
>> brian
>> 
>> 
>> 
>> ------------------------------------------------------------------------------
>> This SF.net email is sponsored by Windows:
>> 
>> Build for Windows Store.
>> 
>> http://p.sf.net/sfu/windows-dev2dev
>> _______________________________________________
>> sleuthkit-users mailing list
>> https://lists.sourceforge.net/lists/listinfo/sleuthkit-users
>> http://www.sleuthkit.org