Re: [sleuthkit-users] fls simply reports usage information?

[Brian C. <ca...@sl...>]

On Jan 6, 2005, at 11:57 PM, Seth Arnold wrote:

> On Thu, Jan 06, 2005 at 09:41:57AM -0500, Brian Carrier wrote:
>> I just fixed that so that all 'usage' statements have an error.  There
>
> Brian, thank you for your quick fix. It made it easy to find the bug. 
> :)
>
> The problem is that getopt() will return a character in the normal case
> and a negative integer in the failure case.

Interesting.  I have actually spent the last day cleaning up all of the 
variables (version 2 is on its way - I am finishing up support for disk 
images!) and I fixed those instances.  I hadn't heard of them causing 
problems before.  It must be a change in libc.

> Thanks also for showing consistent discipline in your programs -- it
> was very easy to track down a few more programs that exhibit this 
> error.
> Attached is a patch that will correct these errors. (Please forgive me 
> my
> indulgence of re-indenting a handful of lines in the switch statement. 
> I
> found the original a little difficult to read. If you'd rather keep the
> indenting the way it was, it should be easy to undo my changes by 
> hand. :)

Thanks.

Yea, the indenting (especially of the switches) has gotten out of hand. 
  I have changed editors a couple of times and that has made it worse.  
I applied indent to the v2 tree.

brian