[sleuthkit-developers] Dereferencing null pointer error in ntfs_dent.c

[Aaron B. <aar...@gm...>]

Hi,

I ran Xcode's static analyzer on TSK and it flagged this error:

.../sleuthkit/xcode/../tsk3/fs/ntfs_dent.c:123:31: warning: Dereference of null pointer
                         prev->next = map;
                               ^

The context is below, which is appears to be a legitimate error:

            else {
                NTFS_PAR_MAP *prev = NULL;
                // somewhere in the middle of the list
                for (tmp = ntfs->orphan_map; tmp; tmp = tmp->next) {
                    if (tmp->par_addr > par) {
                        map->next = tmp;
                        prev->next = map;
                        break;
                    }
                    prev = tmp;
                }

                // at the end of the list
                if (map->next == NULL)
                    prev->next = map;
            }


Regards,

Aaron