[sleuthkit-developers] [ sleuthkit-Bugs-2941813 ] HFSX case sensitivity internal constants named backwards

[SourceForge.net <no...@so...>]

Bugs item #2941813, was opened at 2010-01-28 15:25
Message generated for change (Settings changed) made by carrier
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=477889&aid=2941813&group_id=55685

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: File System Tools
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Rob (robjoyce)
>Assigned to: Brian Carrier (carrier)
Summary: HFSX case sensitivity internal constants named backwards

Initial Comment:
The internal constants in tsk_hfs.h, HFS_BT_HEAD_COMP_SENS and HFS_BT_HEAD_COMP_INSENS, have swapped names: the value for HFS_BT_HEAD_COMP_SENS is currently 0xCF ("case folding") and HFS_BT_HEAD_COMP_INSENS is 0xBC ("binary compare"), but they should be reversed.  But then the code that tests against these constants is also backward: it sets hfs->is_case_sensitive to 1 if the flag matches HFS_BT_HEAD_COMP_INSENS and 0 if it matches HFS_BT_HEAD_COMP_SENS.

So the net effect is that hfs->is_case_sensitive is set correctly.  But someone reading the code, or trying to use the HFS_BT_HEAD_COMP_* constants directly, would be very confused.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=477889&aid=2941813&group_id=55685