[sleuthkit-developers] [ sleuthkit-Bugs-2677107 ] Sleuthkit restricts AFF support

[SourceForge.net <no...@so...>]

Bugs item #2677107, was opened at 2009-03-10 12:34
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=477889&aid=2677107&group_id=55685

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Image File Tools
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Michael Cohen (scudette)
Assigned to: Nobody/Anonymous (nobody)
Summary: Sleuthkit restricts AFF support

Initial Comment:
The AFF library has a vnode interface allowing it to transparently support multiple image types, however in Sleuthkit we have code like (aff.c):

   else if (type == AF_IDENTIFY_AFF) {
        img_info->itype = TSK_IMG_TYPE_AFF_AFF;
    }
    else if (type == AF_IDENTIFY_AFD) {
        img_info->itype = TSK_IMG_TYPE_AFF_AFD;
    }
    else if (type == AF_IDENTIFY_AFM) {
        img_info->itype = TSK_IMG_TYPE_AFF_AFM;
    }  else {
        tsk_error_reset();
        tsk_errno = TSK_ERR_IMG_MAGIC;
        snprintf(tsk_errstr, TSK_ERRSTR_L,
            "aff_open: Not an AFF, AFD, or AFM file");
        free(aff_info);
        if (tsk_verbose)
            tsk_fprintf(stderr, "Not an AFF/AFD/AFM file\n");

        return NULL;
    }

etc

This does not allow afflib to present other types of images than those which sleuthkit specifically knows about.

Sleuthkit should just trap errors from afflib and allow it to handle everything else by itself. I realise this might interfere with sleuthkit's own support for ewf etc. So maybe this should only be allowed where the -i switch is specifically given to use afflib.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=477889&aid=2677107&group_id=55685