[sleuthkit-developers] Valgrind problems with iso9660

[Michael C. <scu...@gm...>]

Hi All,
  I was tracking down a crash in pyflag's sk support and ran valgrind
on fls with an iso image. It turns out that in iso9660.c at line 406
the structure in_inode is allocated, but not initialised. This may
cause a crash later in line 571:

   if (in_node->inode.rr)
                        free(in_node->inode.rr);

(because there could be any rubbish in there).

I found that a             memset(in_node, 0 , sizeof(iso9660_inode_node));
right after the allocation at line 412 fixed things.

Also added a     memset(&t, 0, sizeof(t));
at line 869 to stop other valgrind complaints.

Probably not a bad idea to run valgrind over all the sk tools now and
again. The ntfs drivers are certainly very quiet with valgrind which
is great.

Thanks,
Michael.