#2 0609a: don't use rendered if gSkin not mainpage

closed
None
5
2004-07-08
2004-03-05
No

The way it works right now, story_text.rendered is only for the
"index" section.

If we end up having a sitewide "main" skin, then presumably this
behavior should stay the same.

If not, and I hope not, then we need to either:

1. have freshenup.pl know when to write the 'rendered' data (only
for stories that appear only in one skin?)

2. junk 'rendered' entirely

or (probably best) 3. write separate 'rendered' data for each story-
skin combination (this means a new table, but probably not much
impact on DB performance because of the query cache)

Discussion

  • Jamie McCarthy

    Jamie McCarthy - 2004-06-09
    • assigned_to: jamiemccarthy --> nobody
    • summary: story_text.rendered is skin-specific --> 0609a: don't use rendered if gSkin not mainpage
     
  • Jamie McCarthy

    Jamie McCarthy - 2004-06-09

    Logged In: YES
    user_id=3889

    The story_text.rendered field will always be written with the mainpage.
    This means in index.pl, we will have to just ignore it if gSkin.skid !=
    mainpage_skid.

    Some stories will have rendered data that never gets used (to be
    specific, 'section-only' stories). Oh well.

    Ultimately we'd like to end up with separate 'rendered' data for each
    story-skin combination used, but that optimization would only help us by
    a few percentage points (and what we will need to optimize is DB,
    anyway, not index.pl webhead CPU).

     
  • Jamie McCarthy

    Jamie McCarthy - 2004-06-15
    • assigned_to: nobody --> pudge
     
  • Chris Nandor

    Chris Nandor - 2004-06-15
    • assigned_to: pudge --> jamiemccarthy
     
  • Chris Nandor

    Chris Nandor - 2004-06-15

    Logged In: YES
    user_id=3660

    Just changed the basic logic to look at skid as you said.

     
  • Jamie McCarthy

    Jamie McCarthy - 2004-07-08

    Logged In: YES
    user_id=3889

    Yup, fixed.

     
  • Jamie McCarthy

    Jamie McCarthy - 2004-07-08
    • status: open --> closed
     

Log in to post a comment.