From: Scott M. S. <sc...@ki...> - 2002-03-07 15:18:30
|
I ran into a problem recently with the search plugin (Slash 2.2.5) and am looking to see if others have seen the same. I checked through the archives and didn't see anything close to this, so I apologize if it has been addressed before. I noticed yesterday that if a person searched for comments on my site (threshold 0, all sections, all topics, default order) the resulting hyperlinks had a problem. The comment links were of the form: <slashsite>/article.pl?sid=nn/nn/nn/..&cid=<comment id> When a user clicked the link, expecting to be taken to the comment itself, the resulting page was simply the article view (as if they had clicked the "attached to" link). This functionality didn't seem to match what I had expected - one would assume clicking the comment link would bring up the comment itself. Given that my site is still small, it wasn't a big deal to browse through the comments to see which one you wanted; I still thought this was an important bug. Now, I started my site a few months ago and had upgraded from 2.2.0 to 2.2.4 and currently 2.2.5, so I wondered if perhaps this "bug" was something I caused (or was caused during the updates). I tried a few of the recent "Yass" sites on Slashcode and found that some others exhibited this same behavior. Try the "search.pl" on "slash.geekizoid.com" or on "seiler.manitowoc.wi.us" as examples. I noticed on the sites that did seem to work properly (like Slashcode or Slashdot), the URL was different - the script being called as "comments.pl", not "article". They also seemed to use the discussion "id", not the "sid", but this doesn't seem to make a difference - comments.pl seems to work just as well no matter which identifier you use. I poked around the search templates, search.pl and later Search.pm to see where the decision to call "article.pl" was being made. I found the answer inside the "findComments" subroutine in Slash.pm. This routine returns (among other things) the value of "url" from the "discussions" table. These values seem to be almost always "article.pl", "journal.pl" or "pollBooth.pl". I suppose one might find a "comments" URL here is the discussion isn't attached to a story, journal or poll, but at any rate I had found my answer. The "commentsearch" template used the URL returned as the base URL for linking to the comments. I didn't see any other "sid"s returned by the query given, so there was no other item in the "comments" array to key on in the template. I modified the query in Search.pm to return an additional parameter, discussions.id, and re-built the template for "commentsearch" and this seems to have worked out. I haven't ventured through the rest of the Slash code to see if any portions are relying on the size of the array to be constant, so I can't guarantee I didn't break anything else in the process. Given that "Seach" is a plugin, one would imagine it isn't heavily used within the rest of Slash (for cases where the user disabled it in favor of another search). Any comments are welcome - I've only been playing with Slash for a few months, so I don't purport to know much about what I'm doing. I'm very comfortable with perl (use it extensively myself), but I'm not up on all the intricacies of Slash. The Slash book helped, but I think a good code-reading may be in order ;) Apologies for the size of this message. I just wanted to make sure I included all the gory details. -- Scott M. Sorrentino <sc...@ki...> http://www.kill-hup.com/ Never send mixed SIGnals.... |
From: \dan flickinger\ <fl...@xm...> - 2002-03-07 15:46:29
|
On Thu, 7 Mar 2002, Scott M. Sorrentino wrote: > Try the "search.pl" on "slash.geekizoid.com" or on "seiler.manitowoc.wi.us" as > examples. For the record, I'm the admin of slash.geekizoid.com; search.pl has had this problem since we were running 2.0.0pre3. I was under the impression that something wasn't quite upgraded properly, but I've been too busy to do anything about it. Search.pl had other problems before, but nothing major. [I'm running slashcode 2.2.5 right now without any major problems aside from losing 98% of the readership to the scoop geekizoid site.] It's been on my list for some time, but I have bigger fish to _fry_. (Okay, dumb pun.. shoot me now.) /dan flickinger aka 'flikx' |
From: Brian A. <br...@ta...> - 2002-03-07 17:59:44
|
On Thu, 2002-03-07 at 07:46, "dan flickinger" wrote: > For the record, I'm the admin of slash.geekizoid.com; search.pl has had > this problem since we were running 2.0.0pre3. I was under the impression > that something wasn't quite upgraded properly, but I've been too busy to > do anything about it. Search.pl had other problems before, but nothing > major. [I'm running slashcode 2.2.5 right now without any major problems > aside from losing 98% of the readership to the scoop geekizoid site.] I would suggest pulling a copy from CVS and using the latest version from CVS. -Brian -- _______________________________________________________ Brian Aker, br...@ta... Slashdot Senior Developer Seattle, Washington http://tangent.org/~brian/ http://askbrian.org/ _______________________________________________________ You can't grep a dead tree. |