From: Chris N. <pu...@po...> - 2001-04-12 15:36:08
|
Can anyone who has seen the problem of new stories being posted, but not displaying on index.pl, give me any details beyond this short description of what is happening? Maybe check writestatus/displaystatus of the records in both the stories and newstories tables? -- Chris Nandor pu...@po... http://pudge.net/ Open Source Development Network pu...@os... http://osdn.com/ |
From: <as...@en...> - 2001-04-12 16:32:12
|
I'm trying to refer to a section's name from within the index.pl file. This works nicely from article.pl -- $section.title and $section.section -- but index.pl seems blind to its origins. I see that slashdisplay is what sends the template its variables, but I don't understand how the DBI works enough to be able to add to the variables that the index template receives. Hope I'm being clear. Can anyone help? It should only be a line or two of code added index.pl . In fact, maybe index.pl already does know its own section but it's simply accessed another way. Adam as...@en... |
From: Chris N. <pu...@po...> - 2001-04-12 17:43:20
|
At 19:29 +0200 2001.04.12, as...@en... wrote: >I'm trying to refer to a section's name from within the index.pl file. This >works nicely from article.pl -- $section.title and $section.section -- but >index.pl seems blind to its origins. I see that slashdisplay is what sends >the template its variables, but I don't understand how the DBI works enough >to be able to add to the variables that the index template receives. >Can anyone help? It should only be a line or two of code added index.pl . In >fact, maybe index.pl already does know its own section but it's simply >accessed another way. Well, if index.pl is set to a particular section, you should be able to get it with $form.section, since that is the only way I know of to set index.pl to a particular section. -- Chris Nandor pu...@po... http://pudge.net/ Open Source Development Network pu...@os... http://osdn.com/ |
From: <as...@en...> - 2001-04-12 18:17:29
|
> Well, if index.pl is set to a particular section, you should be able to get > it with $form.section, since that is the only way I know of to set index.pl > to a particular section. > > Chris Nandor pu...@po... Ah yes, form.section does the trick! Thank you. Well, half of it: does index.pl also know the section's display title? I don't have too many so I can just do a loop within the template, ie, [% IF form.section == "courses"] Seminars & Courses [% END %] but I'd prefer to do it more cleanly if the data's accessible. AsK as...@en... |
From: Chris N. <pu...@po...> - 2001-04-12 18:32:24
|
At 21:15 +0200 2001.04.12, as...@en... wrote: >> Well, if index.pl is set to a particular section, you should be able to >get >> it with $form.section, since that is the only way I know of to set >index.pl >> to a particular section. >> >> Chris Nandor pu...@po... > >Ah yes, form.section does the trick! Thank you. > >Well, half of it: does index.pl also know the section's display title? I >don't have too many so I can just do a loop within the template, ie, > >[% IF form.section == "courses"] >Seminars & Courses >[% END %] > >but I'd prefer to do it more cleanly if the data's accessible. [% USE Slash; sections = Slash.db.getDescriptions("sections") %] [% sections.${form.section} %] Now, there is an extra performance hit to call the getDescriptions method (did you know you can call any Slash::DB method that way?), but the data is cached, so it is not a big hit as far as data access is concerned. -- Chris Nandor pu...@po... http://pudge.net/ Open Source Development Network pu...@os... http://osdn.com/ |
From: <as...@en...> - 2001-04-12 19:00:08
|
> > does index.pl also know the section's display title? > [% USE Slash; sections = Slash.db.getDescriptions("sections") %] > > [% sections.${form.section} %] > > Now, there is an extra performance hit to call the getDescriptions method > (did you know you can call any Slash::DB method that way?), but the data is > cached, so it is not a big hit as far as data access is concerned. > > Chris Nandor Works very nicely. Just right, and no I didn't know, but now I do! (I'm using it for a "Home > Sham Supersection > Section" navigation tree at the top of each screen.) Thanks a lot, Adam K as...@en... |
From: <as...@en...> - 2001-04-12 17:12:32
|
I'm wondering where to switch on the 'magic' variable, which appears at the beginning of the displaystory template to toggle whether a story's section gets displayed as part of its title. I'd like to have it off for individual articles and particular indexes, but on for the front page, where stories appear from various sections. I can't think how best to do this. How can displaystory know when it's being called from the front page? Adam K as...@en... |
From: Chris N. <pu...@po...> - 2001-04-12 17:43:19
|
At 20:10 +0200 2001.04.12, as...@en... wrote: >I'm wondering where to switch on the 'magic' variable, which appears at the >beginning of the displaystory template to toggle whether a story's section >gets displayed as part of its title. I'd like to have it off for individual >articles and particular indexes, but on for the front page, where stories >appear from various sections. I can't think how best to do this. How can >displaystory know when it's being called from the front page? Well, you can just add that logic to the template itself. For example, you have now: [% IF magic; title = "..."; ELSE; title = story.title; END %] You can add on top of that: [% IF foo == 1; magic = 1; ELSE; magic = 0; END %] However, I am not sure what you want to do, exactly. It looks like the behavior you want is the behavior that it has right now. How exactly would you want to change the behavior? Although now that I look at it, the code in dispStory() looks busted. It looks like: magic => (!$full && index($story->{title}, ':') == (-1 && ($story->{section} ne $constants->{defaultsection}) && ($story->{section} ne $form_section))), But should be this: magic => (!$full && index($story->{title}, ':') == -1 && ($story->{section} ne $constants->{defaultsection}) && ($story->{section} ne $form_section)), Anyway, if you can help me out with your needs, maybe we can figure it out. -- Chris Nandor pu...@po... http://pudge.net/ Open Source Development Network pu...@os... http://osdn.com/ |
From: <as...@en...> - 2001-04-12 18:49:09
|
Pudge responds: > Well, you can just add that logic to the template itself. For example, you > have now: > > [% IF magic; > title = "..."; > ELSE; > title = story.title; > END %] > > You can add on top of that: > > [% IF foo == 1; > magic = 1; > ELSE; > magic = 0; > END %] > > However, I am not sure what you want to do, exactly. It looks like the > behavior you want is the behavior that it has right now. How exactly would > you want to change the behavior? > > Although now that I look at it, the code in dispStory() looks busted. It > looks like: > > magic => (!$full && index($story->{title}, ':') == (-1 > && ($story->{section} ne $constants->{defaultsection}) > && ($story->{section} ne $form_section))), > > But should be this: > > magic => (!$full && index($story->{title}, ':') == -1 > && ($story->{section} ne $constants->{defaultsection}) > && ($story->{section} ne $form_section)), > > Anyway, if you can help me out with your needs, maybe we can figure it out. I'm not after anything fancy, just the usual behavior from Slash1, but as it stands, magic is always off and sections don't ever appear as part of titles. I changed the code as you point out in Slash.pm, but still none. Basically, I want it off everywhere except on the front page, and the magic => code is a little beyond me. I'm looking at Slashcode to see if it's working there and yes it is. But I notice that on one YASS story (NoLogo.org up and running with Bender), YASS appears both in the title and in the storylink although there are no comments. But in LinuxHardware.org Is A Slashsite, YASS doesn't appear in storylink. Do you reckon magic is just not set up right at the moment? Adam as...@en... |
From: Chris N. <pu...@po...> - 2001-04-12 19:24:55
|
At 21:46 +0200 2001.04.12, as...@en... wrote: >I'm not after anything fancy, just the usual behavior from Slash1, but as it >stands, magic is always off and sections don't ever appear as part of >titles. I changed the code as you point out in Slash.pm, but still none. >Basically, I want it off everywhere except on the front page, and the magic >=> code is a little beyond me. OK, I made the change noted in the email (just now, not when you checked) on slashcode.com, and it is working now. The sticky bit is that if the title contains ":", then it will not print the section. This is so people won't have "YASS: YASS: Cool new site". So on http://slashcode.com/index.pl, you see the first Ask Slashcode story "Site Violates Slash License: What to do?" and the second "Ask Slashcode: Specifying the Charset". Again, here is the correct code to use: magic => (!$full && index($story->{title}, ':') == -1 && ($story->{section} ne $constants->{defaultsection}) && ($story->{section} ne $form_section)), There were some extra, errant parentheses in the old version. -- Chris Nandor pu...@po... http://pudge.net/ Open Source Development Network pu...@os... http://osdn.com/ |
From: Adam K. <as...@en...> - 2001-04-13 19:45:37
|
> Again, here is the correct code to use: > > magic => (!$full && index($story->{title}, ':') == -1 > && ($story->{section} ne $constants->{defaultsection}) > && ($story->{section} ne $form_section)), > > There were some extra, errant parentheses in the old version. > > Chris Nandor OK, now working nicely! Thanks again, Adam as...@en... |
From: Chris N. <pu...@po...> - 2001-04-13 20:14:51
|
At 22:43 +0200 2001.04.13, Adam Khan wrote: >OK, now working nicely! Excellent! Thanks for the report. -- Chris Nandor pu...@po... http://pudge.net/ Open Source Development Network pu...@os... http://osdn.com/ |
From: <as...@en...> - 2001-04-12 17:22:33
|
> Can anyone who has seen the problem of new stories being posted, but not > displaying on index.pl, give me any details beyond this short description > of what is happening? Maybe check writestatus/displaystatus of the records > in both the stories and newstories tables? I think it's because the default setting for the number of articles that a section displays is set to 1 or something. I changed it to 60 or something high and now stories display fine. Adam K as...@en... |
From: Chris N. <pu...@po...> - 2001-04-12 17:35:13
|
At 20:20 +0200 2001.04.12, as...@en... wrote: >> Can anyone who has seen the problem of new stories being posted, but not >> displaying on index.pl, give me any details beyond this short description >> of what is happening? Maybe check writestatus/displaystatus of the >records >> in both the stories and newstories tables? > >I think it's because the default setting for the number of articles that a >section displays is set to 1 or something. I changed it to 60 or something >high and now stories display fine. I am pretty sure there is something else. I remember posting stories on /code and seeing them not show up until I went in and hit "Update" on the story editing screen. I should have looked at the data in the DB before making changes, but I didn't. -- Chris Nandor pu...@po... http://pudge.net/ Open Source Development Network pu...@os... http://osdn.com/ |
From: Adam K. <as...@en...> - 2001-04-14 17:39:49
|
The ability to switch off comments has been deprecated from something that appears just below the story title (ok, it didn't work, but the thought was there) to having to do something with line 39 of article.pl: printComments($form->{sid}); Ideally, this should be togglable in [page:article; template:display], as switching off comments is an important capability. For instance, a site's static pages, eg, faq.shtml, should probably be stories-w/o-comments that can be modified using admin.pl . Adam K as...@en... |
From: Chris N. <pu...@po...> - 2001-04-16 13:28:18
|
At 20:37 +0200 2001.04.14, Adam Khan wrote: >The ability to switch off comments has been deprecated from something that >appears just below the story title (ok, it didn't work, but the thought was >there) to having to do something with line 39 of article.pl: > > printComments($form->{sid}); > >Ideally, this should be togglable in [page:article; template:display], as >switching off comments is an important capability. For instance, a site's >static pages, eg, faq.shtml, should probably be stories-w/o-comments that >can be modified using admin.pl . We would need to disallow posting of comments, too, though. This would just be a hacked-in workaround, not a real solution. What should happen is that a story can have a flag, and when you go to create a comment, view a comment, etc., the flag is checked. I don't know how this should be done, but you should make sure Jamie and Brian see this, so they can look at it now (as they are currently rewriting stories and comments as we speak). -- Chris Nandor pu...@po... http://pudge.net/ Open Source Development Network pu...@os... http://osdn.com/ |