slashcode-development

[Slashcode-development] Comments Disabled Mode

[chromatic <chr...@rm...>]

Hi all,

Running from CVS after 2.1.1, I was unable to set the Comments Disabled mode 
on a story through the Admin menu.  Looking through the code, nothing seems 
to care about that flag, beyond setting and retrieving it from the database.  
I've written two very small patches to make things work, and they appear to 
do just fine on my machine.  

The patch offsets may be a little weird, as I've hacked a couple of other 
things that aren't ready yet.

I'd like to run these by you folks first for comments and questions before 
doing anything more with them.

(By the way, there's a newer version of the Print plugin available with some 
bugfixes.  http://wgz.org/chromatic/slash/Print-plugin.tar.gz)

see ya,
-- c

Re: [Slashcode-development] Comments Disabled Mode

[Chris N. <pu...@po...>]

At 12:11 -0700 2001.11.05, chromatic wrote:
>Running from CVS after 2.1.1, I was unable to set the Comments Disabled mode
>on a story through the Admin menu.  Looking through the code, nothing seems
>to care about that flag, beyond setting and retrieving it from the database.
>I've written two very small patches to make things work, and they appear to
>do just fine on my machine.
>
>The patch offsets may be a little weird, as I've hacked a couple of other
>things that aren't ready yet.
>
>I'd like to run these by you folks first for comments and questions before
>doing anything more with them.

They look OK to me, but I don't know if there is any other place, offhand,
where the code would need to check.  In any event, it is too late for
2.2.0; it could perhaps be included in 2.2.x later, but I see no big rush,
and no reason not to just stick it in 2.3.x.

-- 
Chris Nandor                      pu...@po...    http://pudge.net/
Open Source Development Network    pu...@os...     http://osdn.com/