slashcode-development

[Slashcode-development] sub Slash::DB::PostgreSQL::getSubmissionForUser

[Alessio B. <al...@al...>]

package Slash::DB::{Postgre|My}SQL, routine getSubmissionForUser,
updated from CVS.

I am a little confused by the SELECT:

in PostgreSQL.pm:

SELECT subid,subj,date_format($dateformat,'m/d  H:i') [...]

in MySQL.pm:

SELECT subid,subj,time [...]

and later

formatDate($submission, 2, 2, '%m/%d  %H:%M');

in Perl.

What is correct? The SQL line for PostgreSQL sure it's not :-)
I believe that date_format should be to_char and 'm/d H:i' with '%'s, at
least.

-- 
Alessio F. Bragadini		al...@al...
APL Financial Services		http://village.albourne.com
Nicosia, Cyprus		 	phone: +357-2-755750

"It is more complicated than you think"
		-- The Eighth Networking Truth from RFC 1925

Re: [Slashcode-development] sub Slash::DB::PostgreSQL::getSubmissionForUser

[Brian A. <br...@ta...>]

Alessio Bragadini wrote:
> What is correct? The SQL line for PostgreSQL sure it's not :-)
> I believe that date_format should be to_char and 'm/d H:i' with '%'s, at
> least.
The one with just time. At this point, all date formatting is occuring
outside fo the database. This is probably a hold over from when
that was not the case.
	-Brian

Re: [Slashcode-development] sub Slash::DB::PostgreSQL::getSubmissionForUser

[Alessio B. <al...@al...>]

Brian Aker wrote:

> At this point, all date formatting is occuring
> outside fo the database. This is probably a hold over from when
> that was not the case.

Ok. There are still two occurences of date_format inside the SQL.
They are in Slash::DB::MySQL::autoUrl and getStoryList.

Do you plan to change them to Perl code, too? Because otherwise we need
a wrapper to map MySql's date_format into PostgreSql's to_char. It's
ready, but it would require plpgsql so it'd be better to leave it out.

-- 
Alessio F. Bragadini		al...@al...
APL Financial Services		http://village.albourne.com
Nicosia, Cyprus		 	phone: +357-2-755750

"It is more complicated than you think"
		-- The Eighth Networking Truth from RFC 1925

Re: [Slashcode-development] sub Slash::DB::PostgreSQL::getSubmissionForUser

[Brian A. <br...@ta...>]

Alessio Bragadini wrote:
> 
> Brian Aker wrote:
> 
> > At this point, all date formatting is occuring
> > outside fo the database. This is probably a hold over from when
> > that was not the case.
> 
> Ok. There are still two occurences of date_format inside the SQL.
> They are in Slash::DB::MySQL::autoUrl and getStoryList.
If you get a chance go to sourceforge and enter this in
as a bug. That will work as a note for me to fix it.
	-Brian
-- 
_______________________________________________________
Brian Aker, br...@ta... 
Slashdot Senior Developer
Seattle, Washington
http://tangent.org/~brian/
http://slashdot.org/
_______________________________________________________
You can't grep a dead tree.

Re: [Slashcode-development] sub Slash::DB::PostgreSQL::getSubmissionForUser

[Alessio B. <al...@al...>]

Brian Aker wrote:

> If you get a chance go to sourceforge and enter this in
> as a bug. That will work as a note for me to fix it.

It's bug #413919

Thanks

-- 
Alessio F. Bragadini		al...@al...
APL Financial Services		http://village.albourne.com
Nicosia, Cyprus		 	phone: +357-2-755750

"It is more complicated than you think"
		-- The Eighth Networking Truth from RFC 1925