slashcode-development

[Slashcode-development] patch for hardcoded CHECKED

[Peter W. <pe...@op...>]

In a couple of places Slash have 'CHECKED' hardcoded. This is then used
on markup like this:

<input type="checkbox" name="reparent" CHECKED>

This is not a problem as long as you are using HTML, but if you are
using XHTML the above markup have to look like this:

<input type="checkbox" name="reparent" checked="checked" />

The attached patch changes 'CHECKED' the source to use a var, that way
it's possible to use XHTML without code changes and still easy to switch
between HTML and XHTML.

Any comments?

-- 
Peter Winnberg <pe...@op...>
Openflows Networks Ltd.

Re: [Slashcode-development] patch for hardcoded CHECKED

[Alessio B. <al...@se...>]

On Fri, 2004-10-01 at 19:37, Peter Winnberg wrote:

> The attached patch changes 'CHECKED' the source to use a var, that way
> it's possible to use XHTML without code changes and still easy to switch
> between HTML and XHTML.
> 
> Any comments?

Seems to me that checked="checked" would we perfectly valid HTML too, so
IMHO the patch could just be applied in any case.

-- 
Alessio Bragadini <al...@se...>
Sevenseas.org Hacking Community