slashcode-development — This list is for development of slashcode, no install questions please.

[Slashcode-development] bad form error with aol/webtv?

[CHRISTOPHER C W. <cc...@ps...>]

Very strange. An overwhelming number of AOL users and WebTV users are reporting
"invalid form key" errors when using my slash site - and it's so bad, they
can't do anything. Create an account or post any comments. Nothing. Anyone
heard of this? And if so, is there a solution?

[Slashcode-development] menus

[Shane <sh...@lo...>]

what's preferred - templates or the menu's table?

is the menu's table slated to go away?

why i ask:

i had a plugin, a long time ago, that added admin-functionality. it 
added an 'info' menu item.

sometime, somewhere, it seems the admin menu became a template. my 
plugin can't tap into that template with an automated install, w/o 
overwriting the template, thereby possibly overwriting any 
customizations made.

any thoughts?

  Shane


--
http://shane.lottadot.com/

RE: [Slashcode-development] Side effects of making a topic a nexus?

[Gaulin, M. <mg...@gl...>]

Hi Shane
Thanks again for the explanation, and the confirmation that what I want =
to do should work. I believe I fixed my problem by changing the code a =
bit. I'm going to run my changes by the original author to see if they =
are right.
Thanks
  Mark

-----Original Message-----
From: Shane [mailto:sh...@lo...]
Sent: Thursday, March 03, 2005 5:25 PM
To: Gaulin, Mark
Cc: sla...@li...
Subject: Re: [Slashcode-development] Side effects of making a topic a
nexus?



A skin is the equivlant of a 'section'.

The skin kinda brings it all together, including the graphical-changes=20
in appearance, if any, you'd want.

So, to answer your questions: yes, a skin gives you distinct sets of=20
articles - based on the skins.nexus. Since the nexus is a group of=20
topics - any story posted w/ a topic that's in that nexus is shown in=20
that skin. (well, depending on how you've arranged your topic=20
parent/children and the topics-list in each story).

I believe nexuses and skins are supposed to be 1-1, because you can=20
only assign a single nexus to any one skin.

A topic seems to only have topic-extras when it's marked as a nexus. So=20
you'd have to mark your 'book reviews' topic as being a Nexus. But you=20
don't necessarily have to associate a Nexus with a skin that I can see.=20
So I think you're OK with what you want to do.

  Shane




On Mar 3, 2005, at 4:05 PM, Gaulin, Mark wrote:

> Hi Shane
> I don't think I want the topic to be a skin, but that may be because I =

> don't know what a skin is for. Looking at the skins table definition,=20
> it seems that you want a skin if you want to have a different host=20
> name, indexhandler, and I'm not sure, but does it also give you a=20
> distinct set of articles on the "home" page (for that host name)?  I=20
> don't want any of those things for this topic/nexus (called Book=20
> Reviews), I just want to have topic_nexus_extras that are different=20
> than the Main Page (it's parent topic).
>
> Are nexuses and skins always supposed to be 1-to-1?  I would think=20
> not, but that could be part of my problem.
>
> Thanks
> 	Mark
>
>
> -----Original Message-----
> From: Shane [mailto:sh...@lo...]
> Sent: Thursday, March 03, 2005 1:28 PM
> To: Gaulin, Mark
> Cc: sla...@li...
> Subject: Re: [Slashcode-development] Side effects of making a topic a
> nexus?
>
>
>
> On Mar 3, 2005, at 11:40 AM, Gaulin, Mark wrote:
>
>> Hi
>> In order to get unique "extras" (from topic_nexus_extras) for a topic
>> I have, it looks like I need to convert the topic to a nexus, which
>> could be as simple as checking the Nexus box on the Topics Editor
>> page.  So far so good.  My question is, will anything else change for
>> that topic, assuming I don't change anything else?
>>
>> Thanks
>> 	Mark
>
> I don't think so. Just realize that making it a nexus doesn't
> necessarily make it a skin, if that's what you're going after.
>
>   Shane
>
>
>
--
http://shane.lottadot.com/

Re: [Slashcode-development] Side effects of making a topic a nexus?

[Shane <sh...@lo...>]

A skin is the equivlant of a 'section'.

The skin kinda brings it all together, including the graphical-changes 
in appearance, if any, you'd want.

So, to answer your questions: yes, a skin gives you distinct sets of 
articles - based on the skins.nexus. Since the nexus is a group of 
topics - any story posted w/ a topic that's in that nexus is shown in 
that skin. (well, depending on how you've arranged your topic 
parent/children and the topics-list in each story).

I believe nexuses and skins are supposed to be 1-1, because you can 
only assign a single nexus to any one skin.

A topic seems to only have topic-extras when it's marked as a nexus. So 
you'd have to mark your 'book reviews' topic as being a Nexus. But you 
don't necessarily have to associate a Nexus with a skin that I can see. 
So I think you're OK with what you want to do.

  Shane




On Mar 3, 2005, at 4:05 PM, Gaulin, Mark wrote:

> Hi Shane
> I don't think I want the topic to be a skin, but that may be because I 
> don't know what a skin is for. Looking at the skins table definition, 
> it seems that you want a skin if you want to have a different host 
> name, indexhandler, and I'm not sure, but does it also give you a 
> distinct set of articles on the "home" page (for that host name)?  I 
> don't want any of those things for this topic/nexus (called Book 
> Reviews), I just want to have topic_nexus_extras that are different 
> than the Main Page (it's parent topic).
>
> Are nexuses and skins always supposed to be 1-to-1?  I would think 
> not, but that could be part of my problem.
>
> Thanks
> 	Mark
>
>
> -----Original Message-----
> From: Shane [mailto:sh...@lo...]
> Sent: Thursday, March 03, 2005 1:28 PM
> To: Gaulin, Mark
> Cc: sla...@li...
> Subject: Re: [Slashcode-development] Side effects of making a topic a
> nexus?
>
>
>
> On Mar 3, 2005, at 11:40 AM, Gaulin, Mark wrote:
>
>> Hi
>> In order to get unique "extras" (from topic_nexus_extras) for a topic
>> I have, it looks like I need to convert the topic to a nexus, which
>> could be as simple as checking the Nexus box on the Topics Editor
>> page.  So far so good.  My question is, will anything else change for
>> that topic, assuming I don't change anything else?
>>
>> Thanks
>> 	Mark
>
> I don't think so. Just realize that making it a nexus doesn't
> necessarily make it a skin, if that's what you're going after.
>
>   Shane
>
>
>
--
http://shane.lottadot.com/

RE: [Slashcode-development] Side effects of making a topic a nexus?

[Gaulin, M. <mg...@gl...>]

Hi Shane
I don't think I want the topic to be a skin, but that may be because I =
don't know what a skin is for. Looking at the skins table definition, it =
seems that you want a skin if you want to have a different host name, =
indexhandler, and I'm not sure, but does it also give you a distinct set =
of articles on the "home" page (for that host name)?  I don't want any =
of those things for this topic/nexus (called Book Reviews), I just want =
to have topic_nexus_extras that are different than the Main Page (it's =
parent topic).

Are nexuses and skins always supposed to be 1-to-1?  I would think not, =
but that could be part of my problem.

Thanks
	Mark


-----Original Message-----
From: Shane [mailto:sh...@lo...]
Sent: Thursday, March 03, 2005 1:28 PM
To: Gaulin, Mark
Cc: sla...@li...
Subject: Re: [Slashcode-development] Side effects of making a topic a
nexus?



On Mar 3, 2005, at 11:40 AM, Gaulin, Mark wrote:

> Hi
> In order to get unique "extras" (from topic_nexus_extras) for a topic=20
> I have, it looks like I need to convert the topic to a nexus, which=20
> could be as simple as checking the Nexus box on the Topics Editor=20
> page.  So far so good.  My question is, will anything else change for=20
> that topic, assuming I don't change anything else?
>
> Thanks
> 	Mark

I don't think so. Just realize that making it a nexus doesn't=20
necessarily make it a skin, if that's what you're going after.

  Shane

Re: [Slashcode-development] Side effects of making a topic a nexus?

[Shane <sh...@lo...>]

On Mar 3, 2005, at 11:40 AM, Gaulin, Mark wrote:

> Hi
> In order to get unique "extras" (from topic_nexus_extras) for a topic 
> I have, it looks like I need to convert the topic to a nexus, which 
> could be as simple as checking the Nexus box on the Topics Editor 
> page.  So far so good.  My question is, will anything else change for 
> that topic, assuming I don't change anything else?
>
> Thanks
> 	Mark

I don't think so. Just realize that making it a nexus doesn't 
necessarily make it a skin, if that's what you're going after.

  Shane

[Slashcode-development] Side effects of making a topic a nexus?

[Gaulin, M. <mg...@gl...>]

Hi
In order to get unique "extras" (from topic_nexus_extras) for a topic I =
have, it looks like I need to convert the topic to a nexus, which could =
be as simple as checking the Nexus box on the Topics Editor page.  So =
far so good.  My question is, will anything else change for that topic, =
assuming I don't change anything else? =20

Thanks
	Mark

[Slashcode-development] forums look?

[Shane <sh...@lo...>]

Wasn't there someone that was working on code/templates for a more 
'ubb/forum' discussion interface for slash?

I recall seeing some code committed into the stock src a while back.

I was just wondering if anything ever came of it, or if it's planned 
that something will?

  Shane


--
http://shane.lottadot.com/

[Slashcode-development] blocks, bids, sections and skins

[Shane <sh...@lo...>]

Before skins, blocks could have a bid of "sectionname_blockname". Now  
that we have skins, what's the preferred method to do this?

A look at the blocks schema shows an integer for all_skins, a varchar  
skin, and no skid.

So - I would think that the "sectionname_blockname" bid naming  
convention is now depricated because the varchar(30) skin can be  
defined for a particular block?

Any thoughts on this?

Thanks,
  Shane



mysql> describe blocks;
+--------------+--------------------------+------+-----+--------- 
+-------+
| Field        | Type                     | Null | Key | Default |  
Extra |
+--------------+--------------------------+------+-----+--------- 
+-------+
| bid          | varchar(30)              |      | PRI |         |       
  |
| block        | text                     | YES  |     | NULL    |       
  |
| seclev       | mediumint(8) unsigned    |      |     | 0       |       
  |
| type         | enum('static','portald') |      | MUL | static  |       
  |
| description  | text                     | YES  |     | NULL    |       
  |
| skin         | varchar(30)              |      | MUL |         |       
  |
| ordernum     | tinyint(4)               | YES  |     | 0       |       
  |
| title        | varchar(128)             |      |     |         |       
  |
| portal       | tinyint(4)               |      |     | 0       |       
  |
| url          | varchar(128)             | YES  |     | NULL    |       
  |
| rdf          | varchar(255)             | YES  |     | NULL    |       
  |
| retrieve     | tinyint(4)               |      |     | 0       |       
  |
| last_update  | timestamp(14)            | YES  |     | NULL    |       
  |
| rss_template | varchar(30)              | YES  |     | NULL    |       
  |
| items        | smallint(6)              |      |     | 0       |       
  |
| autosubmit   | enum('no','yes')         |      |     | no      |       
  |
| rss_cookie   | varchar(255)             | YES  |     | NULL    |       
  |
| all_skins    | tinyint(4)               |      |     | 0       |       
  |
+--------------+--------------------------+------+-----+--------- 
+-------+
18 rows in set (0.00 sec)

RE: [Slashcode-development] Suggestions for "topic description" design

[Gaulin, M. <mg...@gl...>]

As it turns out, I need to insert my new stuff right in the middle of =
the searchform template, so I have my answer.
  Mark

-----Original Message-----
From: sla...@li...
[mailto:sla...@li...]On Behalf Of
Gaulin, Mark
Sent: Thursday, February 03, 2005 10:17 AM
To: sla...@li...
Subject: [Slashcode-development] Suggestions for "topic description"
design


Hi
We want to have an option "descriptive paragraph" (arbitrary html) for =
each topic, so that new users to our site will know what the different =
topics are intended to cover. The topics.pl page is probably the user's =
first introduction to the set of all topics, so I figure the target of =
the links from that page (search.pl) would be a good place to start, =
with additional places identified later.

So, my idea is to create a new template that takes the current topic id =
as input and "somehow" fetches and displays the description text. (My =
first implementation of this template will probably be a big switch, =
with topic text hard-coded right there. That logic can be factored out =
later.) =20

Anyway, it seems like I have two choices for how to get this new =
template called on the search.pl page: add a call to the new template in =
an existing template that search.pl already loads, or add a new call =
directly in search.pl.

How would you guys decide which way to go?

Thanks
	Mark


-------------------------------------------------------
This SF.Net email is sponsored by: IntelliVIEW -- Interactive Reporting
Tool for open source databases. Create drag-&-drop reports. Save time
by over 75%! Publish reports on the web. Export to DOC, XLS, RTF, etc.
Download a FREE copy at http://www.intelliview.com/go/osdn_nl
_______________________________________________
Slashcode-development mailing list
Sla...@li...
https://lists.sourceforge.net/lists/listinfo/slashcode-development

[Slashcode-development] Suggestions for "topic description" design

[Gaulin, M. <mg...@gl...>]

Hi
We want to have an option "descriptive paragraph" (arbitrary html) for =
each topic, so that new users to our site will know what the different =
topics are intended to cover. The topics.pl page is probably the user's =
first introduction to the set of all topics, so I figure the target of =
the links from that page (search.pl) would be a good place to start, =
with additional places identified later.

So, my idea is to create a new template that takes the current topic id =
as input and "somehow" fetches and displays the description text. (My =
first implementation of this template will probably be a big switch, =
with topic text hard-coded right there. That logic can be factored out =
later.) =20

Anyway, it seems like I have two choices for how to get this new =
template called on the search.pl page: add a call to the new template in =
an existing template that search.pl already loads, or add a new call =
directly in search.pl.

How would you guys decide which way to go?

Thanks
	Mark

[Slashcode-development] [PATCH] Title of Message Preferences Page

[Oliver M. B. <ol...@fa...>]

Hi!

The page for configuring messages doesn't have an adequate title. I've
added one and below is the trivial patch to make the title configurable.

I've been recently sending misc patches that do not really add functionality
but might make an admin of a slashcode site slightly more happy. With
zero response, I'm wondering wheter you havn't looked at the patches at all 
yet, or if you are simply not interested in this kind of patches?

--- Messages/messages.pl	31 Dec 2004 12:36:50 -0000	1.3
+++ Messages/messages.pl	12 Jan 2005 08:59:33 -0000
@@ -211,7 +211,8 @@
 	slashDisplay('prefs_titlebar', {
 		nickname => $user->{nickname},
 		uid => $user->{uid},
-		tab_selected => 'messages'
+		tab_selected => 'messages',
+		title => getData( 'prefshead' )
 	});
 	print createMenu('messages');
 	slashDisplay('journuserboxes');
--- Messages/templates/data;messages;default	27 Jan 2004 21:55:00 -0000	1.1.1.1
+++ Messages/templates/data;messages;default	12 Jan 2005 08:59:33 -0000
@@ -18,6 +18,10 @@
 	[% returnme.data_constant = 1 %]
 	[% constants.sitename %] Message Center
 
+[% CASE 'prefshead' %]
+	[% returnme.data_constant = 1 %]
+	Message Options
+
 [% CASE 'prefs saved' %]
 	[% returnme.data_constant = 1 %]
 	Preferences Saved


-- 
	Oliver M. Bolzer

GPG (PGP) Fingerprint = 621B 52F6 2AC1 36DB 8761  018F 8786 87AD EF50 D1FF

Re: [Slashcode-development] [PATCH] make department name s/ /-/ optional

[Shane <sh...@lo...>]

On Jan 9, 2005, at 6:01 AM, Oliver M. Bolzer wrote:

> Hi!
>
> On slashdot.jp, i like to have spaces in department names from time to 
> time.
> Currently, the conversion of spaces into dashes is hardcoded in 
> admin.pl.
> Below is a patch against R_2_5_0_41 that makes this behaviour optional 
> and
> depend on the var "use_dept_space2dash". It'd be great if this could be
> merged. I'm sure there are other users out there that don't neccersary
> always-want-the-dashes-in-there.

I'll second that.

[Slashcode-development] [PATCH] make department name s/ /-/ optional

[Oliver M. B. <ol...@fa...>]

Hi!

On slashdot.jp, i like to have spaces in department names from time to time.
Currently, the conversion of spaces into dashes is hardcoded in admin.pl.
Below is a patch against R_2_5_0_41 that makes this behaviour optional and
depend on the var "use_dept_space2dash". It'd be great if this could be
merged. I'm sure there are other users out there that don't neccersary
always-want-the-dashes-in-there.

Index: admin.pl
===================================================================
RCS file: /cvsroot/slashdotjp/slashjp/plugins/Admin/admin.pl,v
retrieving revision 1.3
diff -u -r1.3 admin.pl
--- admin.pl	31 Dec 2004 12:35:50 -0000	1.3
+++ admin.pl	9 Jan 2005 10:48:09 -0000
@@ -1327,9 +1327,11 @@
 		$storyref->{commentstatus} = $form->{commentstatus};
 
 		$storyref->{uid} ||= $user->{uid};
-		$storyref->{dept} =~ s/[-\s]+/-/g;
-		$storyref->{dept} =~ s/^-//;
-		$storyref->{dept} =~ s/-$//;
+		if ($constants->{use_dept_space2dash}){
+			$storyref->{dept} =~ s/[-\s]+/-/g;
+			$storyref->{dept} =~ s/^-//;
+			$storyref->{dept} =~ s/-$//;
+		}
 
 		my($chosen_hr) = extractChosenFromForm($form);
 		$storyref->{topics_chosen} = $chosen_hr;
@@ -1501,7 +1503,7 @@
 	my $authors = $slashdb->getDescriptions('authors', '', 1);
 	my $author_select = createSelect('uid', $authors, $storyref->{uid}, 1);
 
-	$storyref->{dept} =~ s/ /-/gi;
+	$storyref->{dept} =~ s/ /-/gi if $constants->{use_dept_space2dash};
 
 	$locktest = lockTest($storyref->{title});
 
@@ -1941,7 +1943,7 @@
 	my $tid_ref;
 	my $default_set = 0;
 
-	$form->{dept} =~ s/ /-/g;
+	$form->{dept} =~ s/ /-/g if $constants->{use_dept_space2dash};
 
 	$form->{aid} = $slashdb->getStory($form->{sid}, 'aid', 1)
 		unless $form->{aid};
@@ -2267,7 +2269,7 @@
 	my $tid_ref;
 	my $default_set = 0;
 
-	$form->{dept} =~ s/ /-/g;
+	$form->{dept} =~ s/ /-/g if $constants->{use_dept_space2dash};
 
 	my($chosen_hr) = extractChosenFromForm($form);
 	my($tids) = $slashdb->getTopiclistFromChosen($chosen_hr);
Index: dump
===================================================================
RCS file: /cvsroot/slashdotjp/slashjp/plugins/Admin/dump,v
retrieving revision 1.3
diff -u -r1.3 dump
--- dump	31 Dec 2004 12:35:50 -0000	1.3
+++ dump	9 Jan 2005 10:48:09 -0000
@@ -31,6 +31,7 @@
 INSERT INTO menus (menu, label, sel_label, value, seclev, menuorder) VALUES ('info','Config','Config','[% gSkin.rootdir %]/admin.pl?op=topics',500,13);
 
 INSERT INTO vars (name, value, description) VALUES ('admin_maxdays_divider', '14', 'Max number of days on the admin.pl story list to bother showing the day-dividers');
+INSERT INTO vars (name, value, description) VALUES ('use_dept_space2dash','1','convert spaces to dashes in dept. field');
 INSERT INTO vars (name, value, description) VALUES ('ispell', 'ispell', 'Location of ispell binary or empty string to turn off');
 INSERT INTO vars (name, value, description) VALUES ('similarstorydays', '30', 'Number of days to look back for uncommon words when determining similar stories');
 INSERT INTO vars (name, value, description) VALUES ('similarstorymaxwords', '30', 'Maximum number of top-weighted scores to search for in previous stories');


-- 
	Oliver M. Bolzer

GPG (PGP) Fingerprint = 621B 52F6 2AC1 36DB 8761  018F 8786 87AD EF50 D1FF

[Slashcode-development] slash::stats graphs?

[Shane <sh...@lo...>]

Has anyone tried using Slash::Stat's graphing code to create graphs for 
anything outside of the stats plugin?

If so, I'd like to hear about it. It's one of those things that's been 
on my 'need to look into' list for a while, well, since the plugin was 
released.

  Shane

Re: [Slashcode-development] [PATCH] xmlencode(): make entitizing of non-ASCII-printable characters switchable

[Oliver M. B. <ol...@fa...>]

> The patch below is against R_2_5_0_41 and makes this entitizing dependent
> on a new constant "rss_entitize_nonascii". Please consider it for merge.

Here it is


--- Slash/Utility/Data/Data.pm	3 Jan 2005 09:49:01 -0000
+++ Slash/Utility/Data/Data.pm	4 Jan 2005 10:16:10 -0000
@@ -2875,6 +2875,7 @@
 
 sub xmlencode {
 	my($text, $nohtml) = @_;
+	my $constants = getCurrentStatic();
 
 	# if there is an & that is not part of an entity, convert it
 	# to &
@@ -2885,7 +2886,7 @@
 	$text = XML::Parser::Expat->xml_escape($text, ">");
 
 	# convert ASCII-non-printable to numeric entities
-	$text =~ s/([^\s\040-\176])/ "&#" . ord($1) . ";" /ge;
+	$text =~ s/([^\s\040-\176])/ "&#" . ord($1) . ";" /ge if $constants->{rss_entitize_nonascii};
 
 	return $text;
 }
--- sql/mysql/defaults.sql	31 Dec 2004 12:37:19 -0000
+++ sql/mysql/defaults.sql	4 Jan 2005 10:16:16 -0000
@@ -914,6 +914,7 @@
 INSERT INTO vars (name, value, description) VALUES ('returnto_passwd',CONCAT('changeme',RAND()),'Password used to sign MD5s for returnto URLs from remote sites');
 INSERT INTO vars (name, value, description) VALUES ('rootdir','//www.example.com','Base URL of site; used for creating on-site links that need protocol-inspecific URL (so site can be used via HTTP and HTTPS at the same time)');
 INSERT INTO vars (name, value, description) VALUES ('rss_allow_index', '0', 'Allow RSS feeds to be served from index.pl (1 = admins, 2 = subscribers, 3 = all logged-in users)');
+INSERT INTO vars (name, value, description) VALUES ('rss_entitize_nonascii', 1, 'Convert non-ASCII-printable characters into entities?');
 INSERT INTO vars (name, value, description) VALUES ('rss_expire_days','7','Number of days till we blank the data from the database (the signatures still stick around though)');
 INSERT INTO vars (name, value, description) VALUES ('rss_store','0','Should we be saving incomming submissions for rss');
 INSERT INTO vars (name, value, description) VALUES ('run_ads','0','Should we be running ads?');
-- 
	Oliver M. Bolzer
	ol...@go...

GPG (PGP) Fingerprint = 621B 52F6 2AC1 36DB 8761  018F 8786 87AD EF50 D1FF

[Slashcode-development] [PATCH] xmlencode(): make entitizing of non-ASCII-printable characters switchable

[Oliver M. B. <ol...@fa...>]

Still clearing my personal patch queue ;-)

Slash::Utility::Data::xmlencode() converts all characters that are not
ASCII-printable into entities. This is rather ugly and greatly increases
data size of RSS feeds for sites that mostly have non-ASCII content.
The XML declaration says UTF-8 it the encoding, thus we should be clear to
output UTF-8 characters. And if the input to xmlencode() wasn't UTF-8,
the entitizing wouldn't help anywy. 

The patch below is against R_2_5_0_41 and makes this entitizing dependent
on a new constant "rss_entitize_nonascii". Please consider it for merge.

# I also have a set of patches for a completely UTF-8ized Slashcode, but
# it depends on Perl 5.8, a patch to DBD::MySQL and some ugly trickery
# and is thus not yet ready for public consumption. If anybody is interested,
# I can post some details.

-- 
	Oliver M. Bolzer
	ol...@go...

GPG (PGP) Fingerprint = 621B 52F6 2AC1 36DB 8761  018F 8786 87AD EF50 D1FF

[Slashcode-development] [PATCH] Convert hardcoded Journal RSS' titles to getData()

[Oliver M. B. <ol...@fa...>]

Hi!

Currently the title and descriptions of RSS feeds of Journals is hardcoded in
journal.pl::displayRSS(). I had to translate them for my site into
another language with another grammer, so moved these into the
data;journal;default template. A patch against R_2_5_0_41 is attached.
I'd greatly appreciate it, if the patch (or something similar) could be merged.

Index: journal.pl
===================================================================
RCS file: /cvsroot/slashdotjp/slashjp/plugins/Journal/journal.pl,v
retrieving revision 1.6
diff -u -r1.6 journal.pl
--- journal.pl	31 Dec 2004 12:36:49 -0000	1.6
+++ journal.pl	4 Jan 2005 09:30:45 -0000
@@ -255,21 +255,21 @@
 		($constants->{journal_rdfitemdesc_html} > 2 && !$user->{is_anon})
 	);
 
-	my($title, $journals, $link);
+	my($title, $desc, $link);
 	if ($form->{op} eq 'friendview') {
-		$title    = "$juser->{nickname}'s Friends'";
-		$journals = 'Journals';
+		$title    = getData('rss_fv_title', { nickname => $juser->{nickname} });
+		$desc     = getData('rss_fv_desc', { nickname => $juser->{nickname} });
 		$link     = '/journal/friends/';
 	} else {
-		$title    = "$juser->{nickname}'s";
-		$journals = 'Journal';
+		$title    = getData( 'rss_title', { nickname => $juser->{nickname} });
+		$desc     = getData( 'rss_desc', { nickname => $juser->{nickname} });
 		$link     = '/journal/';
 	}
 
 	xmlDisplay(rss => {
 		channel => {
-			title		=> "$title $journals",
-			description	=> "$title $constants->{sitename} $journals",
+			title		=> $title,
+			description	=> $desc,
 			'link'		=> root2abs() . '/~' . fixparam($juser->{nickname}) . $link,
 			creator		=> $juser->{nickname},
 		},
Index: templates/data;journal;default
===================================================================
RCS file: /cvsroot/slashdotjp/slashjp/plugins/Journal/templates/data;journal;default,v
retrieving revision 1.2
diff -u -r1.2 data;journal;default
--- templates/data;journal;default	31 Dec 2004 12:36:49 -0000	1.2
+++ templates/data;journal;default	4 Jan 2005 09:30:45 -0000
@@ -68,6 +68,18 @@
 	[% returnme.data_constant = 1 %]
 	Sorry, the requested journal entries were not found.
 
+[% CASE 'rss_title' %]
+	[% nickname %]'s Journal
+
+[% CASE 'rss_desc' %]
+	[% nickname %]'s [% constants.sitename %] Journal
+
+[% CASE 'rss_fv_title' %]
+	[% nickname %]'s Friends' Journals
+
+[% CASE 'rss_fv_desc' %]
+	[% nickname %]'s Friends' [% constants.sitename %] Journals
+
 [% END %]
 
 __seclev__


-- 
	Oliver M. Bolzer

GPG (PGP) Fingerprint = 621B 52F6 2AC1 36DB 8761  018F 8786 87AD EF50 D1FF

[Slashcode-development] [PATCH] initialize Lingua::Stem only if stem_uncommon_words is on

[Oliver M. B. <ol...@fa...>]

Hi!

My site uses a language (Japanese) that is not supported by Lingua::Stem
and though I've switched off stemming, Slash::Utility:::Data::findWords()
chokes trying to initialize Lingua::Stem.

Below is a patch that makes the initialization of the stemmer and all
operations on it depend on the stem_uncommon_words var. Please review and
apply.

diff -u -r1.6 Data.pm
--- ./Slash/Utility/Data/Data.pm	31 Dec 2004 12:35:48 -0000	1.6
+++ ./Slash/Utility/Data/Data.pm	2 Jan 2005 10:51:07 -0000
@@ -3243,11 +3243,14 @@
 	my $use_stemming = $constants->{stem_uncommon_words};
 	my $language = $constants->{rdflanguage} || "EN-US";
 	$language = uc($language);
-	my $stemmer = Lingua::Stem->new(-locale => $language);
-	$stemmer->stem_caching({ -level => 2 });
+	my $stemmer;
 	my $text_return_hr = {};
 	my @word_stems;
 
+	if ($use_stemming){
+		$stemmer = Lingua::Stem->new(-locale => $language);
+		$stemmer->stem_caching({ -level => 2 });
+	}
 
 	# Return a hashref;  keys are the words, values are hashrefs
 	# with the number of times they appear and so on.
@@ -3348,7 +3351,7 @@
 			$wordcount->{$word}{count}++;
 		}
 	}
-	$stemmer->clear_stem_cache();
+	$stemmer->clear_stem_cache() if $use_stemming;
 
 	return $wordcount;
 }

-- 
	Oliver M. Bolzer

GPG (PGP) Fingerprint = 621B 52F6 2AC1 36DB 8761  018F 8786 87AD EF50 D1FF

Re: [Slashcode-development] $form data

[James M. <jm...@tr...>]

Disclaimer, I haven't looked in depth at the slashcode core for ages.
(By the way, can we stop bracing for impact anytime soon?).  So what
follows might be out of date compared to the current best practices...


My preferred methods are

parse form for key,value pairs

pass those as an args hash

OR

on creation of handler object, pass the results of get_form (the form)
as one of the hash arguments ('form'=>$form), then in the object
initialization, populate what I need from $form (or save the whole
thing if I am being lazy, and fetch what I need later).  Actually, in
retrospect, I do that, as in 

in parent handler

my $form = getCurrentForm();
...
my $handler = $ops->{$op}->{'class'}->new('form'=>$form,
                                          'user'=>$user,
                                          'op'=>$op);

Inside of handler base class, I have

sub _init {
 ...
 $self->{'_form'}=$args{'form'}; # actually handled in my parent class
                                 # as hash_init
 ...
}

then in my base class I also have

sub form {
    my ($self,$key) = @_;
    if(defined ($key)){
        return $self->{'_form'}->{$key} ;
    }
    return undef;
}

If the child class knows what key it wants (jeez, it better, it is
handling the form response after all), then it just says

my $key = 'superSecretFormKey';
my $value = $self->form($key);

 
There was an earlier comment about Java handling oop in a cleaner way,
or something like that.  I think about the handler and the message
container in oop terms too, its just that my message container is a
hash, which is infinitely flexible for stuffing messages.  When I
programmed an MVC in Java, my generic data object was just a glorfied,
hard-to-use wrapper around a hashtable.  

So in response to your argument, I pass the entire form.  I guess that
sorta maps onto the theory that your code for getting the messages
from the web browser and sending them along to the actual back end
handlers should know as little as possible about what the back end is
doing, what the browser is doing.  As long as the 'op' in the form
resolves to a class in my handler, then I create the class, with the
contents of the form, and call a generic method 'process' that all of
my handler classes implement.  If $form->{'op'} is meaningless, or if
$user->{'seclev'}<$form->{'op'}->{'class'}->minimum_seclev (or
whatever), then I bounce the reply to the default page (usually just
the menu).  What is that called, a transparent contoller?

The handler class has to parse, untaint (I really have no idea what
tainting is, but I need to learn), and approve of the contents
of the form.  If it isn't an int, the handler has to complain.

I've never used Slash::Utility::Environment::filter_params.  Couldn't
you inherit from that class, and override the method filter_params to
additionally parse your data?  But then, if you are only looking at
your data, what is the point of using SlashUtilityEnvironment class?
I guess it would be good if there are generic params you might also be
using.  again, I haven't ever looked at that class.  

(Btw, you can also shove javascript in your template file to validate
form data using the client's CPU cycles if you want, but personally I
try to use javascript as little as possible.  Just for stupid stuff
like scrolling animations of random pictures which sets my laptop
bubbling at 60% cpu....)

my two cents,
james

At approximately Fri, Dec 17, 2004 at 07:54:38AM -0500, Shane wrote:
> What's the general concensus on checking and passing form data?
> 
> If you browse through slash-src, as well as 3rd party released code, 
> people do it many different ways. An example:
> 
> you have a form, and you create a pulldown in the form using 
> Slash.createSelect. it's passing back what's supposed to be an integer, 
> let's call it intID for simplicity's sake. In your perl script, you 
> eventually need to pass this intID to a method in your perl module.
> 
> So do you:
> 
> pass the entire $form
> pass part of the form, $form->{intID}
> 
> where do you do the integer-validity check? or do you patch 
> Slash::Utility::Environment::filter_params and have it do the work for 
> you?
> 
> Obviously, a lot of this "just depends" on what you're coding for. But 
> considering that for everything I've ever coded for slash, I've done 
> all of the above at one time or another for one reason or another.
> 
> The biggest pain, for me, is having to patch Environment.pm to add my 
> vars to filter_params, so I often find that I don't bother with it, and 
> then forget about it.
> 
> I thought I might drum up some discussion, so let's see what y'all 
> think.
> 
>   Shane
> 
> 
> 
> --__--__--

RE: [Slashcode-development] $form data

[Gaulin, M. <mg...@gl...>]

Hi Shane
I haven't written any plugins for slash yet, but I have done a lot of =
development on fairly big and extensible applications (though not in =
perl). To me, it seems a little dangerous for a plugin author to make a =
global decision about how a parameter is to be used... only the =
framework authors get to make global decisions.  (That would suggest not =
adding it to Environment.pl) That said, an extensible framework library =
should make it easy to do common things (like validate parameters), so =
you might expect to see that stuff factored out into generic code, with =
the built-in stuff (like Environment.pm) using that generic code to get =
it's job done.  That leaves the parameter validation up to the plugin =
author (presumably inside their own code) but it should only take a line =
or two to get the job done.

Your question about passing in the whole form or just the arguments =
picked out from the form is tricky... I like to handle user input =
validation and argument "marshalling" all at one layer in the code, near =
the "front", with the "working parts" below it taking explicit arguments =
(vs a bag of arguments).  Sometimes you get into places where it doesn't =
make sense to make arguments out of everything, esp when they are lots =
of parameters or if there are an arbitrary number of them. In those =
cases I like to pull out the fixed arguments and pass them explicitly, =
along with the bag.  There can also a separation of concerns issue here =
too, where there can be so many layers of code that extracting the =
arguments out of the bag early can lead to lots of (pointless) code =
changes whenever a new argument is added, just so they can be passed =
down to where they are really needed.  Even in those cases though, I can =
usually define an object to cover many of the related arguments, and =
then the code changes from passing in lots of little things into passing =
in one bigger thing. (I program in java mostly these days, so the OOP =
stuff is cleaner than in perl, at least to me.)

So, yeah, there is no one right way, but there are certainly ways that =
are easier to live with in the long run.  I like to use those.

	Mark

-----Original Message-----
From: sla...@li...
[mailto:sla...@li...]On Behalf Of
Shane
Sent: Friday, December 17, 2004 7:55 AM
To: sla...@li...
Subject: [Slashcode-development] $form data


What's the general concensus on checking and passing form data?

If you browse through slash-src, as well as 3rd party released code,=20
people do it many different ways. An example:

you have a form, and you create a pulldown in the form using=20
Slash.createSelect. it's passing back what's supposed to be an integer,=20
let's call it intID for simplicity's sake. In your perl script, you=20
eventually need to pass this intID to a method in your perl module.

So do you:

pass the entire $form
pass part of the form, $form->{intID}

where do you do the integer-validity check? or do you patch=20
Slash::Utility::Environment::filter_params and have it do the work for=20
you?

Obviously, a lot of this "just depends" on what you're coding for. But=20
considering that for everything I've ever coded for slash, I've done=20
all of the above at one time or another for one reason or another.

The biggest pain, for me, is having to patch Environment.pm to add my=20
vars to filter_params, so I often find that I don't bother with it, and=20
then forget about it.

I thought I might drum up some discussion, so let's see what y'all=20
think.

  Shane



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.=20
http://productguide.itmanagersjournal.com/
_______________________________________________
Slashcode-development mailing list
Sla...@li...
https://lists.sourceforge.net/lists/listinfo/slashcode-development

[Slashcode-development] $form data

[Shane <sh...@lo...>]

What's the general concensus on checking and passing form data?

If you browse through slash-src, as well as 3rd party released code, 
people do it many different ways. An example:

you have a form, and you create a pulldown in the form using 
Slash.createSelect. it's passing back what's supposed to be an integer, 
let's call it intID for simplicity's sake. In your perl script, you 
eventually need to pass this intID to a method in your perl module.

So do you:

pass the entire $form
pass part of the form, $form->{intID}

where do you do the integer-validity check? or do you patch 
Slash::Utility::Environment::filter_params and have it do the work for 
you?

Obviously, a lot of this "just depends" on what you're coding for. But 
considering that for everything I've ever coded for slash, I've done 
all of the above at one time or another for one reason or another.

The biggest pain, for me, is having to patch Environment.pm to add my 
vars to filter_params, so I often find that I don't bother with it, and 
then forget about it.

I thought I might drum up some discussion, so let's see what y'all 
think.

  Shane

[Slashcode-development] CRM?

[Shane <sh...@lo...>]

Has anyone done any CRM code/plugin under Slash?

Is there anyone that would be interested in such a beast?

  Shane

Re: [Slashcode-development] Slash::Admin topic selection

[Clifton W. <cli...@gm...>]

On Wed, 17 Nov 2004 06:47:11 -0500, Shane <sh...@lo...> wrote:
> Has any of you taken a look at using the Topic-selection code in
> anything other then admin.pl?
> 
> Say, for instance, a plugin? (heh, as if you didn't know where I was
> leading this... )
> 
> The ability to associate a plugin's object w/ one or more topics is
> something that I've wanted for a while. But I've not had time to rip
> apart the admin plugin and find out how it was done. It'd be sweet if
> admin's code/forms could be reused easily.
> 
> Any thoughts?

I'm currently trying to extract part of the Javascript that does all
that into a more generic tool that I can use for ordering other things
in Slash. Right now it's tied tightly to the selection and ordering of
topics, so you may have better luck doing this than I. Much of the
stuff looks to be fairly reusable, but the problem is that for it to
be reusable, you'd need to use the routines in Slash::Admin::PopupTree
(for admin use only), or redesign it for more general use.

- Cliff

[Slashcode-development] Slash::Admin topic selection

[Shane <sh...@lo...>]

Has any of you taken a look at using the Topic-selection code in 
anything other then admin.pl?

Say, for instance, a plugin? (heh, as if you didn't know where I was 
leading this... )

The ability to associate a plugin's object w/ one or more topics is 
something that I've wanted for a while. But I've not had time to rip 
apart the admin plugin and find out how it was done. It'd be sweet if 
admin's code/forms could be reused easily.

Any thoughts?

  Shane