From: Oliver M. B. <ol...@fa...> - 2004-02-10 13:39:10
|
Hi! I'm currently working on migrating my site to the 2_3 code base, adopting it for usage with multi-byte character encodings and making it more translation friendly. One problem I'm having is with the various submit buttons. Most submit buttons are like this: <input type="submit" name="op" value="Preview"/> If I want to translate the button's text, I have to change *.pl's $ops . I used to do that in 2.2.x but there has to be a better way to make button labels code-independend. Forms where there is only one submit button, "op" could be made a hidden field but forms with multiple buttons (especially those sharing a input field) currently can't be translated without changing code. How about making "op" indipendent of the <input/>'s value? E.g. There would be <input type="submit" name="op_post" value="Something" /> and <input type="submit" name="op_submit" value="Else" /> and these get decoded into op=post or op=submit before it reaches *.pl's main(), maybe in Slash::Utility::Environment::filter_params(). That way, the neccersary compatibility changes would be minimal. What do others think? I'll produce a patch if such a change is acceptable for merge. -- Oliver M. Bolzer GPG (PGP) Fingerprint = 621B 52F6 2AC1 36DB 8761 018F 8786 87AD EF50 D1FF |