#425 Similar stories for submitters when new search is enabled

Slash 2.5/3.0

If I read submit.pl previewForm() correctly, getSimilarStories() is
being called, and its results stored, not just for admins but for
ordinary users as they preview their submissions.

We can either stop doing this for non-admins, thus saving some
reader DB time...

or we can add in code that will generate the list of similar stories
for ordinary users (simply omit ND stories) and display it to them
(probably with a line prefacing it saying what it is). This may help
prevent dupes from being submitted, or may inspire readers to link
in earlier stories that are topical.

I don't know the best way to solve this yet.


  • Jamie McCarthy

    Jamie McCarthy - 2004-11-23

    Logged In: YES

    I'm really leaning toward making this information available to
    submitters, after they click Preview, before they click Submit. It's not
    quite a copy-and-paste job since ND stories obviously can't be shown and
    I don't think the API allows that option. But giving this info to submitters
    may get us higher-quality submissions, and we already know it won't kill

  • Jamie McCarthy

    Jamie McCarthy - 2004-11-23
    • assigned_to: jamiemccarthy --> tvroom
  • Tim Vroom

    Tim Vroom - 2004-11-30

    Logged In: YES

    Looked into this and this is only getting called in viewsub
    not preview during submission. The preview during
    submission calls previewStory which doesn't have a
    getSimilarStories call.

    That being said this information would show up to a
    non-admin if $constants->{submiss_view} was turned on. I've
    removed the similarStories for non-admins there.

    Leaving this open for now as a reminder -- just in case we
    want to add similar stories for non-admins during submission
    preview for users. If so we probably want to make it a
    var-controlled option. Often that query can take a long
    time on /., so I'm not sure if we want to add that
    worst-case wait to submission preview -- if we want to try
    it we definitely want the option of turning it off with a var.

  • Jamie McCarthy

    Jamie McCarthy - 2004-11-30

    Logged In: YES

    Sorry to send you on a wild goose chase. When new search code is
    hooked up, yes, let's look into this again.

  • Tim Vroom

    Tim Vroom - 2005-01-10
    • labels: 351677 -->
    • milestone: 416544 --> Slash 2.5/3.0
    • summary: getSimilarStories being called for non-admins --> Similar stories for submitters when new search is enabled

Log in to post a comment.