#3592 tags plugin schema problems

[shane]

the tags plugin won't install, see attached patch to fix it.

Would you like to install all the files as symlinks
to the original? (If not, each file will be copied to
your Slash directories). [Y]
Error:Slash::Install:/usr/lib/perl5/site_perl/5.8.6/i386-linux-thread-
multi/Slash/Install.pm:379:virtuser='whatis' -- hostinfo='sql0 via TCP/
IP' -- Invalid default value for 'inactivated' -- CREATE TABLE tags (
tagid int UNSIGNED NOT NULL AUTO_INCREMENT,
tagnameid int UNSIGNED NOT NULL,
globjid int UNSIGNED NOT NULL,
uid mediumint UNSIGNED NOT NULL,
created_at datetime NOT NULL,
inactivated datetime DEFAULT NULL
PRIMARY KEY tagid (tagid),
KEY tagnameid (tagnameid),
KEY globjid_tagnameid (globjid, tagnameid),
KEY uid_globjid_tagnameid_inactivated (uid, globjid, tagnameid,
inactivated),
KEY created_at (created_at)
) TYPE=InnoDB
Which was called by:Slash::Install:/usr/lib/perl5/site_perl/5.8.6/i386-
linux-thread-multi/Slash/Install.pm:176
=== (Tags) Failed on :CREATE TABLE tags (
tagid int UNSIGNED NOT NULL AUTO_INCREMENT,
tagnameid int UNSIGNED NOT NULL,
globjid int UNSIGNED NOT NULL,
uid mediumint UNSIGNED NOT NULL,
created_at datetime NOT NULL,
inactivated datetime DEFAULT NULL
PRIMARY KEY tagid (tagid),
KEY tagnameid (tagnameid),
KEY globjid_tagnameid (globjid, tagnameid),
KEY uid_globjid_tagnameid_inactivated (uid, globjid, tagnameid,
inactivated),
KEY created_at (created_at)
) TYPE=InnoDB:

[shane]

patch to fix

[Jamie McCarthy]

Logged In: YES
user_id=3889

DEFAULT NULL works fine at least on our test sites (MySQL 4.1.18 and
5.0.18/19). What version MySQL are you on?

I'd rather not have an active tag with a non-NULL value in 'inactivated' if I can
help it, so for now I'm going to leave the schema as is.

[shane]

Logged In: YES
user_id=52587

[shane@sql0 ~]$ mysql -V
mysql Ver 14.7 Distrib 4.1.12, for pc-linux-gnu (i686) using readline 4.3