Re: [Skim-app-develop] [Skim-app-users] Highlighting on Leopard

[Adam R. M. <ama...@ma...>]

If I'm reading the code aright, looks like this is handled in =20
mouseUp:, and mouseUp: doesn't seem to be called at all.

In a quick test project with a PDFView, mouseUp: works fine until a =20
document is loaded, so one of the views inside PDFView is snarfing =20
events and fouling things up.  Likewise, mouseDragged: is never =20
called.  I tried using my hack for NSSplitView, but that made no =20
difference in the test project.

Oh, I also noticed this

                 // due to an Appkit bug, endUndoGrouping registers an =20=

extra change count, which is not reverted when the group is undone
                 [[[[self window] windowController] document] =20
updateChangeCount:NSChangeUndone];

which may be fixed on Leopard if my vague recollection is correct.  =20
Maybe the change count should be checked first?

--=20
adam

On Oct 30, 2007, at 12:37 PM, Christiaan Hofman wrote:

> Adam, could you check if PDFView uses an event loop for selection on
> Leopard? Or otherwise if this could be fixed by calling [super
> mouseDown:] before adding the highlight? (just some random thoughts).
>
> Christiaan
>
> On 30 Oct 2007, at 8:07 PM, Marian D=F6rk wrote:
>
>> Hello,
>>
>> it seems as if highlighting with the Highlight tool is broken on
>> Leopard. Highlighting though works when text is selected with the =20
>> Text
>> Tool and then marked up via the New Highlight command from the Notes
>> menu.
>>
>> Are other users experiencing the same? I just added a bug tracker
>> entry, too.
>>
>> Thanks
>> Marian
>>
>
>
> =
-------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a =20
> browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> skim-app-develop mailing list
> ski...@li...
> https://lists.sourceforge.net/lists/listinfo/skim-app-develop