Menu

#210 Throwable caught in SignalHook.java

open-accepted
nobody
None
5
2007-02-06
2006-10-03
Dan M.
No

SignalHook.java catches and ignores Throwables in
1.16.5. As Hani best put it in www.jroller.com/page/
fate/?anchor=why_i_hate_tomcat

"Yes, even Error type exceptions are caught. Things
that God and Sun never intended for applications to
even try to handle, tomcat will (silently) catch and
ignore. After all, when you run out of memory, best
thing to do is keep going right?"

Discussion

  • Scott G. Miller

    Scott G. Miller - 2006-10-05
    • status: open --> closed-wont-fix
     
  • Scott G. Miller

    Scott G. Miller - 2006-10-05

    Logged In: YES
    user_id=25869

    This is necessary unfortunately, because there are all kinds
    of unrecoverable errors and exceptions which can be thrown
    while calling into arbitrary Scheme code while handling the
    exception. The signal itself is handled in a separate
    thread which terminates immediately after the hook is
    called, so there is no real danger, as the thread won't
    continue after that anyway.

     
  • Dan M.

    Dan M. - 2006-10-05

    Logged In: YES
    user_id=590785

    Are you sure? Throwable's have two derived classes --
    Exception and Error. Catching Exception is fine. Catching
    Error usually makes no sense. Error's are things like: out
    of memory, ThreadDeath, and other fun things. Have a look at

    http://java.sun.com/j2se/1.4.2/docs/api/java/lang/Error.html

     
  • Dan M.

    Dan M. - 2006-10-05
    • status: closed-wont-fix --> open-wont-fix
     
  • Scott G. Miller

    Scott G. Miller - 2007-02-06
    • status: open-wont-fix --> open-accepted
     
  • Scott G. Miller

    Scott G. Miller - 2007-02-06

    Logged In: YES
    user_id=25869
    Originator: NO

    I can't find the reason we used throwable there, so I'll change it to Exception until something breaks. Leaving this bug open to track.

     

Log in to post a comment.

MongoDB Logo MongoDB