siptoolbox-devel

[SIP-devel] Hi,I modified the incluce path of Animal

[Zhang C. <ch...@ma...>]

Hi,

I just use splint to make an analysis to the source code of Animal. In
order to make splint to work fine, I changed the include path from the
form <animal/common.h> to "common.h". IMHO, the current path is more
accurate. Ricardo, can I commit my changes without your permission?;-)

BTW, splint is good tool to analyse source code and point out the
potential bugs at early stage. The software engineers of SUN use it
heavily to promote the quality of their product.

Zhang Cheng

Re: [SIP-devel] Hi,I modified the incluce path of Animal

[Ricardo F. <rf...@gm...>]

Hi, Zhang

> I just use splint to make an analysis to the source code of Animal. In
> order to make splint to work fine, I changed the include path from the
> form <animal/common.h> to "common.h". IMHO, the current path is more
> accurate.=20

I disagree. These files are to be installed in the user's system, e.g.
in /usr/local/include.

Every .h file having an #include directive should use #include<>.

Anyways, splint is good and it is nice that you know how to use it (I
never did). Thanks for the suggestion/disposition.
--=20
Ricardo Fabbri

PhD Student in Computer Engineering / Computer Vision
LEMS - Laboratory for Engineering Man-Machine Systems
Brown University, USA

Re: [SIP-devel] Hi,I modified the incluce path of Animal

[Zhang C. <ch...@ma...>]

Hi, Ricardo

       I just ./configure, make and make install the modified Animal. 
All the libraries and header files
are installed correctly. So I think #include <> has nothing with the 
installation path.

Zhang Cheng


Ricardo Fabbri wrote:

>Hi, Zhang
>
>  
>
>>I just use splint to make an analysis to the source code of Animal. In
>>order to make splint to work fine, I changed the include path from the
>>form <animal/common.h> to "common.h". IMHO, the current path is more
>>accurate. 
>>    
>>
>
>I disagree. These files are to be installed in the user's system, e.g.
>in /usr/local/include.
>
>Every .h file having an #include directive should use #include<>.
>
>Anyways, splint is good and it is nice that you know how to use it (I
>never did). Thanks for the suggestion/disposition.
>  
>

Re: [SIP-devel] Hi,I modified the incluce path of Animal

[Ricardo F. <rf...@gm...>]

On 7/23/05, Zhang Cheng <ch...@ma...> wrote:
> Hi, Ricardo
>=20
>        I just ./configure, make and make install the modified Animal.
> All the libraries and header files
> are installed correctly. So I think #include <> has nothing with the
> installation path.

Ok. I tought that #include <> would search the GCC include path given
by -I flags.
#include "" searchs in the same directory as the file which includes the he=
ader.
Before comitting the code, please try the following test:
- compile and install animal
- compile SIP

If SIP compiles properlly with your changes, you may comit your
changes to animal.

Thanks!
--=20
Ricardo Fabbri

PhD Student in Computer Engineering / Computer Vision
LEMS - Laboratory for Engineering Man-Machine Systems
Brown University, USA

Re: [SIP-devel] Hi,I modified the incluce path of Animal

[Ricardo F. <rf...@gm...>]

> I just use splint to make an analysis to the source code of Animal. In
> order to make splint to work fine, I changed the include path from the
> form <animal/common.h> to "common.h". IMHO, the current path is more
> accurate. Ricardo, can I commit my changes without your permission?;-)

Hi  Zhang

Please make sure you are using splint correctly. It should have a flag
for searching include files. The way animal currently is just like,
e.g. GTK is built.
Try using -I  (include) flags in splint. If that doesn't work, you
have to give a clear reason before making any changes in working code.

For example, -I/usr/local/lib or -I/home/zhang/path/to/animal

cheers,
--=20
Ricardo Fabbri

PhD Student in Computer Engineering / Computer Vision
LEMS - Laboratory for Engineering Man-Machine Systems
Brown University, USA

Re: [SIP-devel] Hi,I modified the incluce path of Animal

[Zhang C. <ch...@ma...>]

Hi, Ricardo

I'm sorry to commit my changes without careful consideration. You're 
right, I should not modify #include<>.
Because I'm new to splint too, I didn't notice the -I flag. I'll be more 
careful before commit any changes.

Zhang Cheng

Ricardo Fabbri wrote:

>>I just use splint to make an analysis to the source code of Animal. In
>>order to make splint to work fine, I changed the include path from the
>>form <animal/common.h> to "common.h". IMHO, the current path is more
>>accurate. Ricardo, can I commit my changes without your permission?;-)
>>    
>>
>
>Hi  Zhang
>
>Please make sure you are using splint correctly. It should have a flag
>for searching include files. The way animal currently is just like,
>e.g. GTK is built.
>Try using -I  (include) flags in splint. If that doesn't work, you
>have to give a clear reason before making any changes in working code.
>
>For example, -I/usr/local/lib or -I/home/zhang/path/to/animal
>
>cheers,
>  
>