Re: [Sipp-users] call.cpp bug fix in revision 1.9.2.38 breaks compatibility for other parameters

[Dragos V. <dra...@fo...>]

Oh, and while we are in call.cpp :-p, I have another observation:

#define KEYWORD_SIZE 64

This value is a little too low. I suggest a change to 128.
Again, my problem is with authorization, as I have for example a 10 
chars long username  and a  8 chars  long password. So:

[authorization username=sub...@um... password=12345678] 
has 70 characters.

-Dragos-

Dragos Vingarzan wrote:
> Hello Olivier,
>
> You have committed a bug fix with the following description:
>
> "Fixed bug for offset keyword as well as add negative offset support 
> (+ and - keywords) - provided by Peter Higginson."
>
> I believe that the changed lines are:
>
>    // allow +/-n for numeric variables
>    if ((key = strchr(keyword,'+')) || (key = strchr(keyword,'-'))) {
>           offset = atoi(key);
>           *key = 0;
>    } else offset = 0;
>
>
> This unfortunately breaks other scenarios. For example:
>
> [authentication username=vin...@op... password=xxx]
>
> doesn't work properly as the above sequence overwrites the '-' in the 
> domain name.
>
> I would fix it myself, but I don't know all the implications of 
> offset. Can you please do that?
>
> Thanx,
> Dragos
>
>

-- 
-----------------------------------------
Dipl. Eng. Dragos Vingarzan
FOKUS/NGNI
Kaiserin-Augusta-Allee 31
10589 Berlin,Germany
Phone +49 (0)30 - 3463 - 7385
Mobile +49 (0)162 - 153 - 0154
eMail vin...@fo...
Web www.fokus.fraunhofer.de
We could change the world if God would give us the source code...
-------------------------------------------------------