#358 FTBFS with glib-2.0 >= 2.62.0

[Geiger David]

Hi,

On Mageia Cauldron pidgin-sipe 1.24.0 fails to build with latest Glib2 2.61.2:

sipe-utils.c:293:3: error: 'GTimeVal' is deprecated: Use 'GDateTime' instead [-Werror=deprecated-declarations]
   GTimeVal currtime;
   ^~~~~~~~
In file included from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from sipe-utils.c:29:
/usr/include/glib-2.0/glib/gtypes.h:551:8: note: declared here
 struct _GTimeVal
        ^~~~~~~~~
sipe-utils.c:297:3: error: 'g_get_current_time' is deprecated: Use 'g_get_real_time' instead [-Werror=deprecated-declarations]
   g_get_current_time(&currtime);
   ^~~~~~~~~~~~~~~~~~
In file included from /usr/include/glib-2.0/glib/giochannel.h:33,
                 from /usr/include/glib-2.0/glib.h:54,
                 from sipe-utils.c:29:
/usr/include/glib-2.0/glib/gmain.h:575:8: note: declared here
 void   g_get_current_time                 (GTimeVal       *result);
        ^~~~~~~~~~~~~~~~~~
sipe-utils.c:298:3: error: 'g_time_val_to_iso8601' is deprecated: Use 'g_date_time_format' instead [-Werror=deprecated-declarations]
   time_str = g_time_val_to_iso8601(&currtime);
   ^~~~~~~~
In file included from /usr/include/glib-2.0/glib.h:88,
                 from sipe-utils.c:29:
/usr/include/glib-2.0/glib/gtimer.h:73:10: note: declared here
 gchar*   g_time_val_to_iso8601   (GTimeVal    *time_) G_GNUC_MALLOC;
          ^~~~~~~~~~~~~~~~~~~~~
sipe-utils.c: In function 'sipe_utils_str_to_time':
sipe-utils.c:335:2: error: 'GTimeVal' is deprecated: Use 'GDateTime' instead [-Werror=deprecated-declarations]
  GTimeVal time;
  ^~~~~~~~
In file included from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from sipe-utils.c:29:
/usr/include/glib-2.0/glib/gtypes.h:551:8: note: declared here
 struct _GTimeVal
        ^~~~~~~~~
sipe-utils.c:348:4: error: 'g_time_val_from_iso8601' is deprecated: Use 'g_date_time_new_from_iso8601' instead [-Werror=deprecated-declarations]
    success = g_time_val_from_iso8601(tmp, &time);
    ^~~~~~~
In file included from /usr/include/glib-2.0/glib.h:88,
                 from sipe-utils.c:29:
/usr/include/glib-2.0/glib/gtimer.h:70:10: note: declared here
 gboolean g_time_val_from_iso8601 (const gchar *iso_date,
          ^~~~~~~~~~~~~~~~~~~~~~~
sipe-utils.c:351:4: error: 'g_time_val_from_iso8601' is deprecated: Use 'g_date_time_new_from_iso8601' instead [-Werror=deprecated-declarations]
    success = g_time_val_from_iso8601(timestamp, &time);
    ^~~~~~~
In file included from /usr/include/glib-2.0/glib.h:88,
                 from sipe-utils.c:29:
/usr/include/glib-2.0/glib/gtimer.h:70:10: note: declared here
 gboolean g_time_val_from_iso8601 (const gchar *iso_date,
          ^~~~~~~~~~~~~~~~~~~~~~~
sipe-utils.c: In function 'sipe_utils_time_to_str':
sipe-utils.c:367:2: error: 'GTimeVal' is deprecated: Use 'GDateTime' instead [-Werror=deprecated-declarations]
  GTimeVal time = { timestamp, 0 };
  ^~~~~~~~
In file included from /usr/include/glib-2.0/glib/galloca.h:32,
                 from /usr/include/glib-2.0/glib.h:30,
                 from sipe-utils.c:29:
/usr/include/glib-2.0/glib/gtypes.h:551:8: note: declared here
 struct _GTimeVal
        ^~~~~~~~~
sipe-utils.c:368:2: error: 'g_time_val_to_iso8601' is deprecated: Use 'g_date_time_format' instead [-Werror=deprecated-declarations]
  return g_time_val_to_iso8601(&time);
  ^~~~~~
In file included from /usr/include/glib-2.0/glib.h:88,
                 from sipe-utils.c:29:
/usr/include/glib-2.0/glib/gtimer.h:73:10: note: declared here
 gchar*   g_time_val_to_iso8601   (GTimeVal    *time_) G_GNUC_MALLOC;
          ^~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [Makefile:1513: libsipe_core_la-sipe-utils.lo] Error 1
make[3]: Leaving directory '/home/pterjan/rpmbuild/BUILD/pidgin-sipe-1.24.0/src/core'
make[3]: *** Waiting for unfinished jobs....

[Stefan Becker]

Thanks. OBS confirms that it also fails on Fedora Rawhide now.

[Stefan Becker]

Partial fix available in git commit d005dafc.

Unfortunately there are more build errors, but not from SIPE code itself. It seems that libpurple 2.x API no longer builds with glib-2.0 >= 2.62.0, e.g.

/usr/include/libpurple/media.h:214:3: error: 'GParameter' is deprecated [-Werror=deprecated-declarations]
  214 |   guint num_params, GParameter *params);
      |   ^~~~~

I'll have to dig in more deeply if this can be fixed via the SIPE build.

[Stefan Becker]

Fixed in git commit 24e6a6d7

Closing as FIXED.

[Stefan Becker]

It turned out that there were even more FTBFS problems: autoreconf failed when gettext >= 0.20.0 was installed on the system. This problem did not affect OBS, but when I tried to push the FTBFS fixes to Fedora 31 & Rawhide.

Fixed in git commit 3a7e482b