Menu

#311 Crash when SIP transport becomes invalid

OBSOLETE_1.20.x
closed-fixed
nobody
None
Crash
5
2018-12-11
2016-04-13
No

Telepathy-sipe crashes when the account contains wrong password. If I fix the correct password it connects correctly to the server (company policy of updating passwords and I forgot to update it here). It should probably fail gracefully rather than coring. See attached core.

1 Attachments

Related

Release Notes: 2016/04/pidgin-sipe-release-1210

Discussion

  • Stefan Becker

    Stefan Becker - 2016-04-13

    Can you please provide the --debug log too? I wonder why send_presence_soap() is called when authentication hasn't been completed yet.

     
  • Tomáš Chvátal

    Seems I can't reproduce it. Now changed the password to garbage and didn't hit the trace. :/
    I will try it while logging in when I stop working today, but it should be the same to set the presence in empathy during the login or while already using the desktop for a while...

     
  • Stefan Becker

    Stefan Becker - 2016-04-13

    I think what happened is that the login succeeded but then the account got disconnected immediately. Stuff got still triggered when the transport was already declared invalid and then sip_transport_request() always returns NULL for the transaction.

    sip-soap.c is one of the places where trans != NULL isn't checked, hence your crash.

     
  • Stefan Becker

    Stefan Becker - 2016-04-13
    • summary: 1.20.1 crashes on attempted login --> Crash when SIP transport becomes invalid
    • status: open --> closed-fixed
     
  • Stefan Becker

    Stefan Becker - 2016-04-13

    This should be fixed by git commit 190d904. It might be rather difficult to reproduce this crash as you probably need to hit an exact time window.

    Closing as FIXED.

     
  • Stefan Becker

    Stefan Becker - 2016-04-13

    OK, now I get it. sipe_core_status_set() got called by the backend before the SIP transport was ready. I guess that case never happens with purple backend, but apparantly with the telepathy backend.

    May I ask why you use the telepathy backend at all? That implementation is incomplete and only allows login, but no chatting. So it is rather useless for end users at the moment.

     

Log in to post a comment.

MongoDB Logo MongoDB