#277 Raised contact names

[Jim Wisniewski]

I recently upgraded from 1.18.0 to 1.18.5 (using Pidgin 2.10.11 on Windows), and I noticed that all the Office Communicator contacts in my buddy list now display with their names raised up as though to make room for a status message underneath, even when there isn't one. This only happens with sipe contacts, not any of the built-in protocols. I hypothesize that the plugin may be telling Pidgin that there is a status string when there isn't one, or giving it an empty string rather than NULL, or something along those lines. It doesn't interfere with actually using Pidgin in any way, but it does look really weird.

[Jim Wisniewski]

Here's an example screenshot of what I'm talking about.

[Stefan Becker]

This regression was unintentionally introduced in 1.18.1 by git commit 3d163da0. This change causes sipe_core_buddy_status() to no longer return NULL but an empty string instead. As I have "Buddies -> Show -> Buddy Details" disabled, I never noticed this regression.

Fixed by git commit 7d706b3