Menu ▾ ▴

#270 HTTP w/o Content-Length header causes crash

OBSOLETE_(1.18.x)
closed-duplicate
Stefan Becker
None
Adium
5
2016-04-23
2014-10-29
Joe
No

As we discussed, when the "Don’t publish calendar information" is not selected then Adium 1.5.11 crashes in Yosemite. I have attached the debug log.

1 Attachments
2014-10-29.log

Discussion

  • Stefan Becker

    Stefan Becker - 2014-10-29
    • summary: Publishing Calendar Info crashes Adium with SIPE in Yosemite --> HTTP w/o Content-Length header causes crash
     

  • Stefan Becker

    Stefan Becker - 2014-10-29

    Thanks for the debug log. Updated subject after brief analysis. The gist from the log is here:

    :::txt
09:35:13: (Libpurple: sipe) transport_input_common: new buffer length 4096
09:35:13: (Libpurple: sipe) transport_input_common: new buffer length 8192
09:35:13: (Libpurple: sipe) sipmsg_parse_header(): Content-Length header not found
09:35:13: (Libpurple: sipe) 
MESSAGE START <<<<<<<<<< HTTP - 2014-10-29T08:35:13.297833Z
HTTP/1.1 405 Access Denied
Server: GoAhead-Webs
Date: Tue May 27 23:29:27 2014
Pragma: no-cache
Cache-Control: no-cache
Content-Type: text/html

MESSAGE END <<<<<<<<<< HTTP - 2014-10-29T08:35:13.297833Z
09:35:13: (Libpurple: sipe) sipe_ews_autodiscover_request: no more methods to try!
09:35:13: (Libpurple: sipe) sipe_calendar_ews_autodiscover_cb: EWS disabled
09:35:13: (Libpurple: sipe) 
MESSAGE START <<<<<<<<<< HTTP - 2014-10-29T08:35:13.313079Z
<html><head><title>Document Error: Access Denied</title></head>
        <body><h2>Access Error: Access Denied</h2>
        <p>Invalid or corrupted session detected. Please close your browser and login again</p></body></html>


MESSAGE END <<<<<<<<<< HTTP - 2014-10-29T08:35:13.313079Z
09:35:13: -[ESDebugController exceptionHandler:shouldLogException:mask:]:76: Exception raised: Uncaught system exception: signal 11

    i.e. the corrupted HTTP response causes the parsing to abort early. The buffer flush then causes the remainder of the message to be passed to SIPE when the corresponding data structures have already been destroyed.

    I vaguely remember a similar crash reason and I thought it was already fixed. I have to check the git log and see if this is a new corner case or something specific to Adium.

     

  • Stefan Becker

    Stefan Becker - 2014-10-29
    • status: open --> closed-duplicate
     

  • Stefan Becker

    Stefan Becker - 2014-10-29

    Found it: [bugs:#240]

    Unfortunately the changes to fix this are too extensive to be included in a bug fix release. The fix will therefore only be available if you use git HEAD or in 1.19.x.

    Closing as DUPLICATE.

     

    Related

    Bugs: #240

  • Stefan Becker

    Stefan Becker - 2014-10-29

    Funny, that bug was also reported by you...

     

    • Joe

      Joe - 2014-10-29

      Ah! :) You had asked me to test it from the HEAD and I never ended up testing it. This time I will make a note to install 1.19.x when it is released and test it.

      Meanwhile, when a new release is done, is there any notification possible such as a mailing list.

       

Log in to post a comment.

MongoDB Logo MongoDB