#241 Adium filters ":" from "sip:"

[Joe]

Hello,

Im trying to add a contact using 1.18.x and Adium 1.5.9. The contact name is added with sip appended to the name. It should have a : between the sip and contact address. sip:my.name@company.com

Because of this, the contact is not added correctly.

Im adding the requested debug log

In the debug log, I tried manually adding the contact sipsudarshans@in.megatrends.com

And while adding I did mention it as sip:sudarshans@in.megatrends.com

But it got added without the ':' as - 'sipsudarshans@in.megatrends.com' and hence I was not successful in communicating with that contact.

Please check.
Thanks

[Stefan Becker]

The debug log shows that the URIs on the contact list delivered by your OCS server are already broken:

<contact uri="parts@..."...  />
<contact uri="sipvinod..." ... />
<contact uri="sipmuthu..." ... />
<contact uri="sipchand..." ... />
<contact uri="sipsagar..." ... />
<contact uri="sipsudar..." ... />

i.e. at some point in the past they got added with the wrong URI to your contact list.

This is not a bug in SIPE. Please delete those entries and re-add them.

Closing as INVALID

[Joe]

Couple of questions

• How/Where to delete these entries
• When I added them, I did put the ':' inside and then tried adding it. Why doesn't it use that URI that I had manually mentioned

[Stefan Becker]

How/Where to delete these entries

As they are invalid URIs, they will always be offline. So enable the "Show offline buddies" (or whatever this is called in Adium) and then delete the offending entries

When I added them, I did put the ':' inside and then tried adding it.
Why doesn't it use that URI that I had manually mentioned

Those entries where not added by SIPE. SIPE checks the URI received in an "add buddy" request:

• if it starts with sip:, then it does not prepend anything,
• if it does not start with sip: it prepends sip:

For the details see sipe_purple_add_buddy(), sip_uri_if_valid() and sipe_core_buddy_add()

Your log shows:

16:31:07: (GLib): (16:31:07) sipe: sipe_purple_add_buddy[CB]: buddy:sipsudar...@XXXXX group:Team
16:31:07: (GLib): (16:31:07) sipe: sipe_buddy_add: Added buddy sip:sipsudar...@XXXXX
....
<action name="subscribe" id="63792024"><adhocList>
<resource uri="sip:sipsudar...@XXXXX"><context/></resource>

Ergo you entered sipsudar...@XXXXX which is of course incorrect.

[Joe]

I followed your steps and when I manually entered without the sip:, then you automatically add the SIP: and it works correctly.

However, there is a mistake in the plugin still. If I add

sip:sudharshan..@xxxx

You have mentioned that if it starts with sip:, then it doesnt prepend anything. That is incorrect. I did add as "sip:sud...@xxx", but the plugin added it as

"sip:sipsudhar...@xxx"

So the bug in the plugin seems to be, it ignores the ':' if I add it manually and then it prepends the "sip:" anyway.

Can you please fix that.

[Stefan Becker]

If your debug log is for the case you entered "sip:sud..." then there is a bug in Adium that filters ":" from the string:

16:31:07: -[AINewContactWindowController addContact:]:201: checkedAccounts is {(
    <ESPurpleSIPEAccount:4228650 8>:jothirams@XXXXX
)}
16:31:07: -[AINewContactWindowController addContact:]:208: Accont <ESPurpleSIPEAccount:4228650 8>:jothirams@XXXXX was checked per its preference; we'll add sipsudarshans@YYYYY to it
16:31:07: -[CBPurpleAccount addContact:toGroup:]:634: <ESPurpleSIPEAccount:4228650 8>:jothirams@XXXX adding sipsudarshans@YYYYY to Team
16:31:07: Adding buddy sipsudarshans@YYYYYY to group Team with alias (null)
16:31:07: (GLib): (16:31:07) sipe: sipe_purple_add_buddy[CB]: buddy:sipsudarshans@YYYYY group:Team

The last line is the first SIPE code line executed and it receives already an incorrect string.

[Joe]

Thanks. I have now submitted the bug to Adium

http://forums.cocoaforge.com/viewtopic.php?f=13&t=26514

[Stefan Becker]

IMHO the only way to get this fixed is to file a real bug report against Adium. I doubt that the developers will react to forum entries.

[Joe]

Ah, Got it. Now filed the bug in their trac

https://trac.adium.im/ticket/16739

[Joe]

Please see response from Adium

https://trac.adium.im/ticket/16739

"This is clearly not a bug in Adium but in the SIPE plugin. ​ESSIPEService.m#l85 shows that the SIPE plugin does not consider ":" a legal character, so Adium strips it. It should add ":" to its -allowedCharacters.

So please contact that author of the plugin, and get him/her to look at it. :)"

It is really not clear if it is your bug or theirs...

[Stefan Becker]

Looks like the original Adium integration author copy & pasted that code straight from another plugin without updating it. According to the git history it hasn't been touched since then.

I have updated the string in git commit 38b355b. I don't have access to a Mac at the moment, so you'll have to compile the code yourself to verify if the problem is solved.

Closing as FIXED.