From: Hedayat V. <hed...@ai...> - 2008-02-22 16:48:22
|
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> </head> <body bgcolor="#ffffff" text="#000000"> Hi,<br> Now, the current CVS head of soccer3d incorporates all of the changes which were available in simspark. The only exceptions are inputwx plugin and rsgedit.<br> <br> As far as I know, the current CVS HEAD should be completely working. You may notice that you get 2 new errors when running the server, that's fine! :) Those are generated by sparkResetScene (spark.rb), and since at the startup there is still no simulationserver when sparkResetScene is called, it prints those errors.<br> <br> Good luck,<br> Hedayat<br> <br> </body> </html> |
From: Markus R. <rol...@un...> - 2008-02-23 09:17:44
|
Hi Hedayat, Hedayat Vatankhah wrote: > Now, the current CVS head of soccer3d incorporates all of the changes > which were available in simspark. The only exceptions are inputwx plugin > and rsgedit. Thanks for moving the changes from the simspark to the soccer3d CVS ;-) The problem is that you moved the changes in one single step into the soccer3d repository. That makes it a bit hard to review and discuss these changes. I'll try to look through the changes and test the build. It would be cool to move rsgedit over as well ;) > As far as I know, the current CVS HEAD should be completely working. You > may notice that you get 2 new errors when running the server, that's > fine! :) Those are generated by sparkResetScene (spark.rb), and since at > the startup there is still no simulationserver when sparkResetScene is > called, it prints those errors. I'll look into that. cheers, Markus |
From: Hedayat V. <hed...@ai...> - 2008-02-23 14:19:18
|
/*Markus Rollmann <rol...@un...>*/ wrote on 02/23/2008 12:47:31 PM: > Hi Hedayat, Hi Markus, > Thanks for moving the changes from the simspark to the soccer3d CVS ;-) :) You're welcome! > The problem is that you moved the changes in one single step into the > soccer3d repository. That makes it a bit hard to review and discuss > these changes. I'll try to look through the changes and test the build. There are some reasons for it: 1. I didn't know that they need discussion, or if anybody is interested in that! ;) 2. I liked to finish this ASAP since I won't have that much free time in the following weeks and I should concentrate on other things for awhile. 3. As far as I know, they don't change the functionality of the current server. They just provide many features which can be used. At least I tried my best to retain 100% compatibility with the past. Thanks for looking through the changes and testing the build. That's really needed. > It would be cool to move rsgedit over as well ;) :) I may do it soon. However, from now on, I'll try to convince you that the best thing for now is to port soccer3d updates in the current simspark code to simspark (some bug fixes, some new features, and some compile fixes) and drop the core libraries (oxygen, kerosin, zeitgeist) and then the general plugins (in spark/plugins) from soccer3d repository ;) Then, regardless of the speed of transition to simspark, there will be always one code tree distributed in simspark and soccer3d repositories. Porting code from one repository to the other is really undesirable. It brings the sense of wasting a lot of time without doing anything new :(. Free time worths a lot more! Personally, I'm almost sure that I'll never port any new changes from simspark to soccer3d! And something I forgot, I didn't port anything from simulation/parts to soccer3d. Is there anything there that should be ported to soccer3d? Thanks again, Hedayat > >> As far as I know, the current CVS HEAD should be completely working. >> You may notice that you get 2 new errors when running the server, >> that's fine! :) Those are generated by sparkResetScene (spark.rb), >> and since at the startup there is still no simulationserver when >> sparkResetScene is called, it prints those errors. > > I'll look into that. > > cheers, > Markus > |
From: Markus R. <rol...@un...> - 2008-02-23 15:00:38
|
Hi, Hedayat Vatankhah wrote: > /*Markus Rollmann <rol...@un...>*/ wrote on 02/23/2008 >> The problem is that you moved the changes in one single step into >> the soccer3d repository. That makes it a bit hard to review and >> discuss these changes. I'll try to look through the changes and >> test the build. > There are some reasons for it: 1. I didn't know that they need > discussion, or if anybody is interested in that! ;) Most of the changes in the simspark CVS were experimental in the sense that they were tested only by very few people (i.e. they worked on my system ;-) Further some changes very motivated only by functionality I needed for rsgedit (e.g. the SceneDictionary that I used to track from which script an object was created). Further I'm not sure if the compile fixes for windows are seperated clean enoguh (some places are littered with #ifdef WIN32 now...) But that are all issues that we can work out. [...] > 3. As far as I know, they don't change the functionality of the > current server. They just provide many features which can be used. At > least I tried my best to retain 100% compatibility with the past. > Thanks for looking through the changes and testing the build. That's > really needed. Your're porting work was done well! I looked through the code and tested the server. It worked without problems for me ;-) >> It would be cool to move rsgedit over as well ;) > :) I may do it soon. However, from now on, I'll try to convince you > that the best thing for now is to port soccer3d updates in the > current simspark code to simspark (some bug fixes, some new features, > and some compile fixes) and drop the core libraries (oxygen, kerosin, > zeitgeist) and then the general plugins (in spark/plugins) from > soccer3d repository ;) [...] I'm ok with switching over to the simspark repository. But moving the code gradually there might make development more complicated (you have to work with two CVS trees in parallel etc.) The original motivation for moving to the simspark CVS was a more strict separation of generic server and simulation specific code. But as a matter of fact the only 'real' simulation is robocup soccer. Therefore I think the pressure to enforce the separation is not there and all changes in this direction are only motivated from a theoretical side. Therefore I still propose to keep the soccer3d repository at least for the near future. > And something I forgot, I didn't port anything from simulation/parts > to soccer3d. Is there anything there that should be ported to > soccer3d? The simulation/parts directory contains the basic .rsg files that are also in the app/simspark/rsg directory of soccer3d. Further some .ros files are located there (these are read by the RosImporter). These can be moved at a later point. cheers, Markus |
From: Hedayat V. <hed...@ai...> - 2008-02-23 16:19:46
|
Hi, /*Markus Rollmann <rol...@un...>*/ wrote on 02/23/2008 06:30:23 PM: > Your're porting work was done well! I looked through the code and > tested the server. It worked without problems for me ;-) Nice :) > Therefore I still propose to keep the soccer3d repository at least for > the near future. That's OK in my opinion if all of the changes go to soccer3d repository from now on (as you mentioned previously). Then the transition to simspark will be only a one way transition. Thanks, Hedayat > > And something I forgot, I didn't port anything from simulation/parts > > to soccer3d. Is there anything there that should be ported to > > soccer3d? > > The simulation/parts directory contains the basic .rsg files that are > also in the app/simspark/rsg directory of soccer3d. Further some .ros > files are located there (these are read by the RosImporter). These can > be moved at a later point. > > cheers, > Markus |