|
From: Hedayat V. <hed...@ai...> - 2010-04-14 20:54:16
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
<title></title>
</head>
<body text="#000000" bgcolor="#ffffff">
Hi Hesham,<br>
<br>
<span>
<style type="text/css">blockquote {color: navy !important; background-color: RGB(245,245,245) !important; padding: 0 15 10 15 !important; margin: 15 0 0 0; border-left: #1010ff 2px solid;} blockquote blockquote {color: maroon !important; background-color: RGB(235,235,235) !important; border-left-color:maroon !important} blockquote blockquote blockquote {color: green !important; background-color: RGB(225,225,225) !important; border-left-color:teal !important} blockquote blockquote blockquote blockquote {color: purple !important; background-color: RGB(215,215,215) !important; border-left-color: purple !important} blockquote blockquote blockquote blockquote blockquote {color: teal !important; background-color: RGB(205,205,205) !important; border-left-color: green !important}</style><i><b>"H.Ebrahimi"
<a class="moz-txt-link-rfc2396E" href="mailto:hes...@gm..."><hes...@gm...></a></b></i> wrote on 04/15/2010 12:54:39
AM +0450:</span><br>
<blockquote
style="border-left: 2px solid rgb(16, 16, 255); color: navy; background-color: rgb(245, 245, 245); padding-left: 15px;"
cite="mid:y2h...@ma..."
type="cite">
<pre wrap="">Hi Hedayat and all,
I have created a new patch, adds the speed controls, fixes a bug, and
tidies up the code.
The fixed bug: when the log player hits the end of log file, it cannot
play backward (using the 'l' key). After applying the patch, when the
end of log file is hit, the player pauses and resets the eof bit of
the input stream. Thus, user can hit 'l', and then 'p' to go backward.
</pre>
</blockquote>
Great!<br>
<br>
<blockquote
style="border-left: 2px solid rgb(16, 16, 255); color: navy; background-color: rgb(245, 245, 245); padding-left: 15px;"
cite="mid:y2h...@ma..."
type="cite">
<pre wrap="">
If it's possible please a more active developer tests this patch :-)
</pre>
</blockquote>
I'll try to test it tomorrow and let you know if there are any
problems. Then you can go on and commit it in SVN (or you might just
commit it if you don't expect any problems, then we will check it from
there!). <br>
<br>
<blockquote
style="border-left: 2px solid rgb(16, 16, 255); color: navy; background-color: rgb(245, 245, 245); padding-left: 15px;"
cite="mid:y2h...@ma..."
type="cite">
<pre wrap="">
Hedayat, is the problem you mentioned about the log recorder and
multi-threading fixed? If not, maybe I can give a hand.
</pre>
</blockquote>
No, I have not found enough free time to put on it yet. It seems that
there are many race conditions in classes which are responsible for
sending monitor information to the monitor/log recorder. Last week I
found one of them in MonitorServer::GetMonitorData and fixed it (it
needed to be protected from simultaneous calls), but later I found that
there are other problems too. You can run the latest simulator with the
default configuration and enable recording log files in simspark.rb,
and then run a binary (e.g. IranOpen 2010 binaries available at:
<a class="moz-txt-link-freetext" href="http://hedayat.fedorapeople.org/iranopen2010/">http://hedayat.fedorapeople.org/iranopen2010/</a>). Usually you will
experience a crash very soon. <br>
<br>
Except on the race conditions when the server is running, it seems that
there are also problems when the monitor sends a command to the server
(e.g. kick off), which should be probably taken care of in
TrainerCommandParser or some of the classes it uses.<br>
<br>
It would be really nice if you fix some/all of the bugs. :)<br>
<br>
Thanks a lot,<br>
Hedayat<br>
<br>
<blockquote
style="border-left: 2px solid rgb(16, 16, 255); color: navy; background-color: rgb(245, 245, 245); padding-left: 15px;"
cite="mid:y2h...@ma..."
type="cite">
<pre wrap="">
Hesham
On 13 April 2010 11:32, H.Ebrahimi <a class="moz-txt-link-rfc2396E" href="mailto:hes...@gm..."><hes...@gm...></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">I've cc'd simspark-devel, in case this discussion should continue.
On 11 April 2010 01:16, Yinon Bentor <a class="moz-txt-link-rfc2396E" href="mailto:yi...@cs..."><yi...@cs...></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Thank you for your suggestion to modify the step delay. �This worked
for us. �Having controls to modify the playback speed may be indeed be
quite useful.
</pre>
</blockquote>
<pre wrap="">
I prepared a patch for this:
<a class="moz-txt-link-freetext" href="http://www.cs.bris.ac.uk/pgrad/ebrahimi/code/rc/logplayer_speed_control.diff">http://www.cs.bris.ac.uk/pgrad/ebrahimi/code/rc/logplayer_speed_control.diff</a>
But I don't have time to test it thoroughly, if you can please give it
a try and let me know if there is a problem. Use the '[' key to slow
down the playback and ']' to speed up.
Hesham
</pre>
<blockquote type="cite">
<pre wrap="">
Thanks,
Yinon
On Fri, Apr 9, 2010 at 11:44 AM, H.Ebrahimi <a class="moz-txt-link-rfc2396E" href="mailto:hes...@gm..."><hes...@gm...></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Yinon, I'm not sure what you mean by replaying log files in real time.
But I explain how you can control the speed of the log player, hope
that helps.
We decided to use a fixed delay time between each cycle for the log
player. If I remember correctly the reason was that the time between
two consecutive cycles depended on the machine. I'm not sure if this
is still the case or not. If you see the log player is playing the log
files very fast, you can modify the delay value in this line of
spark.rb:
� �monitorClient.setStepDelay(3300)
In case you find it handy to have controls in the monitor to increase
and decrease this value while playing a log file, let me know. It's
easy to add these controls. Perhaps it is possible to replace this
fixed time delay with the time measured between two cycles while
running the simulator. Maybe some developers, Hedayat?, can suggest
some ways to improve the logger/log player.
Hesham
On 9 April 2010 08:01, Yinon Bentor <a class="moz-txt-link-rfc2396E" href="mailto:yi...@cs..."><yi...@cs...></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi all,
I'm searching for a way to replay log files in real time instead of
the sped-up replay that seems to be the default in rcssmonitor3d. �Is
there such an option in the monitor?
Thanks,
Yinon</pre>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</blockquote>
</body>
</html>
|