[simspark-svn] SF.net SVN: simspark:[59] trunk/rcssserver3d

[<he...@us...>]

Revision: 59
          http://simspark.svn.sourceforge.net/simspark/?rev=59&view=rev
Author:   hedayat
Date:     2009-04-08 11:39:36 +0000 (Wed, 08 Apr 2009)

Log Message:
-----------
Fixed some warnings

Modified Paths:
--------------
    trunk/rcssserver3d/ChangeLog
    trunk/rcssserver3d/plugin/soccer/beameffector/beamaction.h
    trunk/rcssserver3d/plugin/soccer/kickeffector/kickaction.h
    trunk/rcssserver3d/plugin/soccer/restrictedvisionperceptor/restrictedvisionperceptor.h
    trunk/rcssserver3d/plugin/soccer/soccerbase/soccerbase.cpp
    trunk/rcssserver3d/plugin/soccer/soccerruleaspect/soccerruleaspect.cpp
    trunk/rcssserver3d/plugin/soccer/visionperceptor/visionperceptor.h

Modified: trunk/rcssserver3d/ChangeLog
===================================================================
--- trunk/rcssserver3d/ChangeLog	2009-04-07 08:21:33 UTC (rev 58)
+++ trunk/rcssserver3d/ChangeLog	2009-04-08 11:39:36 UTC (rev 59)
@@ -1,3 +1,19 @@
+2009-04-08  Hedayat Vatankhah  <he...@gr...>
+
+	* plugin/soccer/beameffector/beamaction.h (BeamAction): 
+	- fixed const function declaration
+	
+	* plugin/soccer/soccerbase/soccerbase.cpp (SoccerBase::MoveAgent): 
+	- removed useless statements
+	
+	* plugin/soccer/kickeffector/kickaction.h: 
+	* plugin/soccer/soccerruleaspect/soccerruleaspect.cpp:
+	- fixed variables order in ctor
+	 
+	* plugin/soccer/visionperceptor/visionperceptor.h: 
+	* plugin/soccer/restrictedvisionperceptor/restrictedvisionperceptor.h:
+	- added missing return statement 
+
 2009-03-05  Hedayat Vatankhah  <he...@gr...>
 
 	* linux/rcssserver3d.desktop:

Modified: trunk/rcssserver3d/plugin/soccer/beameffector/beamaction.h
===================================================================
--- trunk/rcssserver3d/plugin/soccer/beameffector/beamaction.h	2009-04-07 08:21:33 UTC (rev 58)
+++ trunk/rcssserver3d/plugin/soccer/beameffector/beamaction.h	2009-04-08 11:39:36 UTC (rev 59)
@@ -33,13 +33,13 @@
     virtual ~BeamAction() {}
 
     /** returns x coord of the position the agent wants to beam to */
-    const float GetPosX() { return mPosX; }
+    float GetPosX() const { return mPosX; }
 
     /** returns x coord of the position the agent wants to beam to */
-    const float GetPosY() { return mPosY; }
+    float GetPosY() const { return mPosY; }
 
     /** returns the stored angle in the x-y-plane */
-    const float GetXYAngle() { return mXYAngle; }
+    float GetXYAngle() const { return mXYAngle; }
 
 protected:
     /** the x coord of the position to beam the agent to */

Modified: trunk/rcssserver3d/plugin/soccer/kickeffector/kickaction.h
===================================================================
--- trunk/rcssserver3d/plugin/soccer/kickeffector/kickaction.h	2009-04-07 08:21:33 UTC (rev 58)
+++ trunk/rcssserver3d/plugin/soccer/kickeffector/kickaction.h	2009-04-08 11:39:36 UTC (rev 59)
@@ -29,7 +29,7 @@
 {
 public:
     KickAction(const std::string& predicate, float phi, float power)
-        : ActionObject(predicate), mKickAngle(phi),mPower(power) {}
+        : ActionObject(predicate), mPower(power), mKickAngle(phi) {}
 
     virtual ~KickAction() {}
 

Modified: trunk/rcssserver3d/plugin/soccer/restrictedvisionperceptor/restrictedvisionperceptor.h
===================================================================
--- trunk/rcssserver3d/plugin/soccer/restrictedvisionperceptor/restrictedvisionperceptor.h	2009-04-07 08:21:33 UTC (rev 58)
+++ trunk/rcssserver3d/plugin/soccer/restrictedvisionperceptor/restrictedvisionperceptor.h	2009-04-08 11:39:36 UTC (rev 59)
@@ -53,6 +53,8 @@
             mTheta   = rhs.mTheta;
             mPhi     = rhs.mPhi;
             mDist    = rhs.mDist;
+
+            return *this;
         }
 
         int operator==(const ObjectData& rhs) const

Modified: trunk/rcssserver3d/plugin/soccer/soccerbase/soccerbase.cpp
===================================================================
--- trunk/rcssserver3d/plugin/soccer/soccerbase/soccerbase.cpp	2009-04-07 08:21:33 UTC (rev 58)
+++ trunk/rcssserver3d/plugin/soccer/soccerbase/soccerbase.cpp	2009-04-08 11:39:36 UTC (rev 59)
@@ -661,7 +661,7 @@
     Leaf::TLeafList::iterator iter = leafList.begin();
 
     // move all child bodies
-    for (iter; iter != leafList.end(); ++iter)
+    for (; iter != leafList.end(); ++iter)
     {
         shared_ptr<Body> childBody =
             shared_dynamic_cast<Body>(*iter);
@@ -715,7 +715,7 @@
     Leaf::TLeafList::iterator iter = leafList.begin();
 
     // move all child bodies
-    for (iter;
+    for (;
          iter != leafList.end();
          ++iter
          )

Modified: trunk/rcssserver3d/plugin/soccer/soccerruleaspect/soccerruleaspect.cpp
===================================================================
--- trunk/rcssserver3d/plugin/soccer/soccerruleaspect/soccerruleaspect.cpp	2009-04-07 08:21:33 UTC (rev 58)
+++ trunk/rcssserver3d/plugin/soccer/soccerruleaspect/soccerruleaspect.cpp	2009-04-08 11:39:36 UTC (rev 59)
@@ -50,10 +50,10 @@
     mSingleHalfTime(false),
     mSayMsgSize(20),
     mAudioCutDist(50.0),
-    mUseOffside(true),
     mFirstCollidingAgent(true),
     mNotOffside(false),
-    mLastModeWasPlayOn(false)
+    mLastModeWasPlayOn(false),
+    mUseOffside(true)
 {
     mFreeKickPos = Vector3f(0.0,0.0,mBallRadius);
 

Modified: trunk/rcssserver3d/plugin/soccer/visionperceptor/visionperceptor.h
===================================================================
--- trunk/rcssserver3d/plugin/soccer/visionperceptor/visionperceptor.h	2009-04-07 08:21:33 UTC (rev 58)
+++ trunk/rcssserver3d/plugin/soccer/visionperceptor/visionperceptor.h	2009-04-08 11:39:36 UTC (rev 59)
@@ -51,6 +51,8 @@
             mTheta   = rhs.mTheta;
             mPhi     = rhs.mPhi;
             mDist    = rhs.mDist;
+
+            return *this;
         }
 
         int operator==(const ObjectData& rhs) const


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.