Re: [Simplog-devel] 0.9.1 is out

[Jim Hu <ji...@ta...>]

Jeremy,

Great!  I just downloaded 0.9.1 and am going through the modified files 
to preserve the customizations I did.  Minor comments:

- It looked like the fix to bug#43 didn't make it into the copy of 
user.php in the release on Sourceforge.
- In blocks.php, insert
	$blogid = $_GET['blogid'];
	at the beginning of the file for the usual register_globals issue.

I also notice that while things are generally working, Simplog 
generates a lot of warnings to my error log.  These don't affect 
whether Simplog works, but they do fill up the error log and make 
debugging things harder.  I've listed below how I've dealt with them, 
but would very much like feedback about whether any of the changes 
proposed below are going to have unintended consequences!

- Many warnings come from entries that do not have trackbacks or 
pingbacks, in which case function list_trackbacks($postid) and function 
list_pingbacks($postid) never define $list, so that return $list gives 
a warning.  I changed return $list to
	if (isset($list)){
     	return $list;
     }else{
     	return null;
     }	
in both functions.  I'm not sure if that's a good solution, but it 
works.

- Other warnings come from undefined stuff in marker_sub.  Looking at 
the code, I'm confused about where $row->fields['date'] comes from.  
I'm clearly missing something!  I changed these to @row->fields['date'] 
to suppress the warnings

- I'm getting undefined warnings for        $this->entryTableName = 
$tableName; in class.blogEntry.php.  Being adventurous, I commented it 
out and can't see any difference in things working.  Does this do 
anything?

- in archive.php and blog.php,

		$line = 
marker_sub(stripslashes($blogInfo->getBlogTemplate()),&$blogEntry, 
&$blogInfo);

my PHP installation gives a warning about pass-by-reference being 
deprecated in this situation.  I removed the "&"s without obvious 
deleterious effects.

- in blocks.php, there is a line that doesn't seem to do anything, but 
which generates a warning:
				$mo = $match[2];
I commented it out.

- In class.Bloginfo.php, there are four places where I think
	$blogEntry = new BlogEntry($rs, $this->blogTableName, $this->blogId);
should be changed to
	$blogEntry = new BlogEntry($rs);

- in news.php line 42,
         array_push($ids,$res->fields[blog_id]);
should be:
         array_push($ids,$res->fields['blog_id']);
with quotes around 'blog_id'

- note that cache directory should be assigned to group www with read & 
write permissions (or whatever is appropriate to allow cache to be 
written)

Finally (Jason, take note!), isUserAuthorized is NOT working properly 
for me.  On my server it's acting like the values in $_SESSION are 
undefined within the function, so it always evaluates false and doesn't 
show the blog entries on a protected blog.  I'm not sure why...I assume 
it works for you guys.  I don't think it has to do with any of the 
modifications I did to my copy, but I'm still checking that.

Jim Hu


On Sep 18, 2004, at 1:18 AM, Jeremy Ashcraft wrote:

> After much procrastination, Simplog 0.9.1 is available for download. 
> This release fixes a few minor bugs in 0.9.
>
> Now the march towards 1.0!
>
>
> -------------------------------------------------------
> This SF.Net email is sponsored by: YOU BE THE JUDGE. Be one of 170
> Project Admins to receive an Apple iPod Mini FREE for your judgement on
> who ports your project to Linux PPC the best. Sponsored by IBM.
> Deadline: Sept. 24. Go here: http://sf.net/ppc_contest.php
> _______________________________________________
> Simplog-devel mailing list
> Sim...@li...
> https://lists.sourceforge.net/lists/listinfo/simplog-devel