#42 Make SimpleBrowser::post() accepting SimpleMultipartEncoding

closed-invalid
None
5
2010-07-27
2010-03-22
No

SimpleBrowser::post() is enforcing use of SimplePostEncoding loosing all the attachments from the $parameters given.
The patch makes it checking for the $parameters type and keeps untouched any objects of type SimplePostEncoding and its descendants (such as SimpleMultipartEncoding), so that attachments are successfully sent.

Discussion

  • Perrick Penet

    Perrick Penet - 2010-07-27

    Hello,

    Your patch was created against an old version of SimpleTest (the current version for HEAD is now 1995). And the browser has seen some dramatic modifications over the last months. If you want to resubmit a patch, please use the current trunk version from source. And if you want to have it included real fast, please add a new unit test as well ;-)

    Yours,
    Perrick

     
  • Perrick Penet

    Perrick Penet - 2010-07-27
    • assigned_to: nobody --> pp11
    • status: open --> closed-invalid
     
  • Nobody/Anonymous

    IrlCpV I value the blog article.Much thanks again. Will read on...

     
  • Nobody/Anonymous

    WFlgxm Enjoyed every bit of your blog.Really looking forward to read more.

     
  • Nobody/Anonymous

    vq7haA Great, thanks for sharing this article.Really thank you! Awesome.

     
  • Nobody/Anonymous

    7iBSfn A big thank you for your post. Will read on...

     

Log in to post a comment.