I applied part of this patch which relates to removing unused variables in cfg.c. It was not causing any problem, but it is cleaner to remove them.
The remaining bulk of this patch just renames 'log' functions with to 'sp_log' everywhere. I do not see why it is necessary. The code compiles without problem with old names. I just checked under Linux and MacOS.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I applied part of this patch which relates to removing unused variables in cfg.c. It was not causing any problem, but it is cleaner to remove them.
The remaining bulk of this patch just renames 'log' functions with to 'sp_log' everywhere. I do not see why it is necessary. The code compiles without problem with old names. I just checked under Linux and MacOS.
Are you compiling with gcc -Wall
?
on the other hand I think it is safer to rename 'log' to 'sp_log' to avoid potential confilict with math function. I will rename.