My hope is that Apple gcc 4.0.1 does not have a stack protector, or that the stack protector is off by default, and that therefore this change will be ok.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
-fno-stack-protector is a speedup optimissation given we do very thorough testing via valgrind, we feel it OK to turn this off. The option is irreleveant if there is no -fsatck-protector. If there is, well it will just slow things down slightly, but hopefully not too much. So removal seems a good plan to me, but only for the versions of gcc for which removal is necessary.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
In MacPorts we are now removing the -fno-stack-protector argument, when using Apple gcc 4.0.1:
https://trac.macports.org/changeset/102365
My hope is that Apple gcc 4.0.1 does not have a stack protector, or that the stack protector is off by default, and that therefore this change will be ok.
-fno-stack-protector is a speedup optimissation given we do very thorough testing via valgrind, we feel it OK to turn this off. The option is irreleveant if there is no -fsatck-protector. If there is, well it will just slow things down slightly, but hopefully not too much. So removal seems a good plan to me, but only for the versions of gcc for which removal is necessary.
Looks like this hasn't been fixed in 1.3.10 yet.
Fixed by https://github.com/silnrsi/graphite/commit/b23ae688f508050a2fb12e6443ce60783b28054e