Sorry - I just had another look through your patch. Would it be possible for you to break your patch up into single logical changes? Also would you like to contribute a patch for the SIGINT issue?
 
Joel
 

On 12 February 2013 at 15:02 "R. Diez" <rdiezmail-comparevcd@yahoo.de> wrote:
> Hi Joel:
>
>
> Please find attached a patch with the kind of small changes I would suggest for PulseView.
>
> How come PulseView ends up including Python headers through sigrokdecode.h? I was hoping that, if the GUI is just using the Python decoders, they would be encapsulated so that the GUI wouldn't need to know anything about Python itself.
>
> By the way, here is an example of how to cleanly exit on Ctrl+C (SIGINT). It uses sockets:
>
>   http://bazaar.launchpad.net/~adamreichold/qpdfview/trunk/view/head:/sources/main.cpp
>   http://bazaar.launchpad.net/~adamreichold/qpdfview/trunk/view/head:/sources/signalhandler.h
>   http://bazaar.launchpad.net/~adamreichold/qpdfview/trunk/view/head:/sources/signalhandler.cpp
>
> More info about that technique is here:
>     http://doc.qt.digia.com/stable/unix-signals.html
>
> Regards,
>    rdiez