sieve-php-devel

[Sieve-php-devel] Bugs in sieve-php

[Oded A. <od...@ge...>]

Hi list

What to do if I find a bug in sieve-php ? 

Can I supply a patch against the current CVS ?

-- 
Oded

::..
"If you piss off enough people, it's hard to tell the difference between 
a distributed denial of service attack and public opinion."
	-- <ignatz> on IRC

[Sieve-php-devel] Re: Bugs in sieve-php

[Alexandros V. <av...@no...>]

Oded Arbel wrote:
> What to do if I find a bug in sieve-php ?
>
> Can I supply a patch against the current CVS ?

Yes, please do. I am listening. :)

Alexandros

[Sieve-php-devel] Re: Bugs in sieve-php

[Oded A. <od...@ge...>]

On Tuesday, 6 =D7=91December 2005 14:33, Alexandros Vellis wrote:
> Wow, nice catch. I didn't find anything in release notes of PHP 5.1,

I didn't either. some trial and error proved my guess was correct ;-)

> it was only this bug report: http://bugs.php.net/bug.php?id=3D31341

Nice - I didn't find that one.

> Nice fix. Also there was one more point where i applied the same fix,
> in a PUTSCRIPT call (see attached patch).

Thanks. I patched my system with that as well.

> The full fix is in CVS now!

Any chance we'll see this fix in the avelsieve packaged with then next=20
squirrelmail version (1.4.6? 1.5.0?) ?

Regards

=2D-=20
Oded

::..
"In the end, everything is a gag."
	-- Charlie Chaplin (1889-1977)

[Sieve-php-devel] Re: Bugs in sieve-php

[Alexandros V. <av...@no...>]

On Tue, 2005-12-06 at 15:55 +0200, Oded Arbel wrote:

> Any chance we'll see this fix in the avelsieve packaged with then next 
> squirrelmail version (1.4.6? 1.5.0?) ?

I've already put it in my avelsieve installation and doing some testing!

Note that avelsieve, as a plugin, is developed independently from
squirrelmail; i.e. it has its own versions and releases. However, since
i'm in the Squirrelmail team as well, I try to make these two work well
together. 8-)


-- 
Alexandros Vellis
av...@no...

[Sieve-php-devel] Re: Bugs in sieve-php

[Alexandros V. <av...@no...>]

On Tue, 2005-12-06 at 15:55 +0200, Oded Arbel wrote:
> > Nice fix. Also there was one more point where i applied the same fix,
> > in a PUTSCRIPT call (see attached patch).
> 
> Thanks. I patched my system with that as well.

Sorry I had it wrong, forgot to put $scriptname out of the quotes.
Please replace line 549 with:

$this->lastcmd = 'PUTSCRIPT "'.$scriptname.'" {'.$len.'+}'."\r
\n".$this->script."\r\n";

:-/

-- 
Alexandros Vellis
av...@no...