Menu

#16 Version information in the menu is aligned too far to the right

None
closed
5
2018-06-18
2016-12-01
compyx
No

When using the SVN version of sidplayfp, the version information line ("Sidplayfp V2.0.0alpha1 ...") is aligned too far to the right, breaking out of the 'box' of the menu.

Attached is a patch to make the version string right-aligned. The patch sucks, since I'm a C coder and not much of a C++ coder. But it should give some idea what I'm talking about.

/Compyx

1 Attachments

Discussion

  • Leandro Nini

    Leandro Nini - 2016-12-01
    • status: open --> accepted
    • assigned_to: Leandro Nini
    • Group: -->
     
  • Leandro Nini

    Leandro Nini - 2016-12-01

    Applied in r2458. I might rework the code later but for now it does the job, thanks!

     
  • compyx

    compyx - 2016-12-01

    You're welcome. I guess first constructing the entire string and then determining the indentation would be better. But I'm not much of a C++ hacker, so I'll leave that to you ;)

     
  • Leandro Nini

    Leandro Nini - 2016-12-04

    Well, the code was broken from the start as it seems that setw only affects the immediately following string. I've followed your suggestion, the code is now more robust and should cope with any string length.

     
  • Leandro Nini

    Leandro Nini - 2016-12-04
    • status: accepted --> fixed
     
  • Leandro Nini

    Leandro Nini - 2018-06-18

    Fixed in 1.4.3.

     
  • Leandro Nini

    Leandro Nini - 2018-06-18
    • status: fixed --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB