Re: [Sharpneat-developers] Hi

[Colin G. <cg...@ds...>]

Ricardo J. M=E9ndez wrote:

>No problem, hadn't posted yet.  Two notes on the code.
>
>In SpeciesForm.cs, there's two lines around line 332 which read:
>
>			int xIncrement =3D pnlMain.Width / colCount;
>			int yIncrement =3D pnlMain.Height / rowCount;
>
>Ocassionaly, colCount or rowCount can be 0, so the program ends with
>an unhandled exception.
> =20
>
Actually I think I've experienced that, but never found where it was.=20
Thanks.

>The second one I'm not sure if it's a bug or not, but on
>XorNetworkEvaluator  			network.ClearSignals() is not called before
>the test case for (1,1), while it is called for the next two.  I
>imagine this can lead to test problems with (1,1), given the
>inter-neuron signals are not being checked.
> =20
>
Yeh this is just wrong. Have made the change here. You probably also=20
noticed I often don't call clear right at the start, which is normally=20
Ok because the network was normally just built, but in the general case=20
it's an assumption and that's bad. Maybe if networks set a flag when=20
they are created (which resets on the first activation) we can check=20
this to determine if a full clear is really required, then we can call=20
clear at the top of all experiments, safe in the knowledge we won't be=20
doing an unnecessary clear.

Cheers,

Colin.