From: Nicklas N. <ex...@us...> - 2004-11-01 21:24:20
|
Update of /cvsroot/sharpcvslib/sharpcvslib/src/ICSharpCode/SharpCvsLib/Misc In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv25998/src/ICSharpCode/SharpCvsLib/Misc Modified Files: CvsRoot.cs PasswordScrambler.cs WorkingDirectory.cs Log Message: * Replaced usage of String.Empty in comparisons with .Length == 0 to enhance performance (FxCop rule) * Excluded a few FxCop rules that did not apply. Index: CvsRoot.cs =================================================================== RCS file: /cvsroot/sharpcvslib/sharpcvslib/src/ICSharpCode/SharpCvsLib/Misc/CvsRoot.cs,v retrieving revision 1.16 retrieving revision 1.17 diff -C2 -d -r1.16 -r1.17 *** CvsRoot.cs 28 Oct 2004 06:42:22 -0000 1.16 --- CvsRoot.cs 1 Nov 2004 21:23:31 -0000 1.17 *************** *** 162,166 **** private string PortString { set { ! if (value != null || value != String.Empty) { try { this.Port = Convert.ToInt32(value); --- 162,166 ---- private string PortString { set { ! if (value != null || value.Length != 0) { try { this.Port = Convert.ToInt32(value); *************** *** 285,289 **** private void AssertNotEmpty(string value, string fieldName) { ! if (null == value || String.Empty == value) { throw new CvsRootParseException( String.Format("{0} must contain a value.", fieldName)); --- 285,289 ---- private void AssertNotEmpty(string value, string fieldName) { ! if (null == value || value.Length == 0) { throw new CvsRootParseException( String.Format("{0} must contain a value.", fieldName)); Index: PasswordScrambler.cs =================================================================== RCS file: /cvsroot/sharpcvslib/sharpcvslib/src/ICSharpCode/SharpCvsLib/Misc/PasswordScrambler.cs,v retrieving revision 1.5 retrieving revision 1.6 diff -C2 -d -r1.5 -r1.6 *** PasswordScrambler.cs 31 Oct 2004 16:17:50 -0000 1.5 --- PasswordScrambler.cs 1 Nov 2004 21:23:31 -0000 1.6 *************** *** 99,103 **** LOGGER.Debug (msg); } ! if (text == null || text == String.Empty) { return str; } --- 99,103 ---- LOGGER.Debug (msg); } ! if (text == null || text.Length == 0) { return str; } Index: WorkingDirectory.cs =================================================================== RCS file: /cvsroot/sharpcvslib/sharpcvslib/src/ICSharpCode/SharpCvsLib/Misc/WorkingDirectory.cs,v retrieving revision 1.21 retrieving revision 1.22 diff -C2 -d -r1.21 -r1.22 *** WorkingDirectory.cs 28 Oct 2004 06:42:22 -0000 1.21 --- WorkingDirectory.cs 1 Nov 2004 21:23:31 -0000 1.22 *************** *** 131,135 **** if (null != this.LocalDirectory) { string tempWorkingPath; ! if (null == this.WorkingDirectoryName || string.Empty == this.WorkingDirectoryName) { tempWorkingPath = this.LocalDirectory; } else { --- 131,135 ---- if (null != this.LocalDirectory) { string tempWorkingPath; ! if (null == this.WorkingDirectoryName || this.WorkingDirectoryName.Length == 0) { tempWorkingPath = this.LocalDirectory; } else { *************** *** 251,255 **** public bool HasOverrideDirectory { get {return !(null == this.OverrideDirectory) && ! !(String.Empty == this.OverrideDirectory);} } --- 251,255 ---- public bool HasOverrideDirectory { get {return !(null == this.OverrideDirectory) && ! !(this.OverrideDirectory.Length == 0);} } |